Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging improvements #344

Merged
merged 8 commits into from
Jun 7, 2023
Merged

Conversation

ianfixes
Copy link
Collaborator

@ianfixes ianfixes commented Jan 18, 2023

Highlights from CHANGELOG.md

  • Using new logging class to remove arbitrary whitespace placement in favor of explicit functionality for adjusting indentation levels.
  • See CHANGELOG.md for more

TODO:

Issues Fixed

exe/arduino_ci.rb Outdated Show resolved Hide resolved
@ianfixes ianfixes force-pushed the 2023-01-18_logging branch 2 times, most recently from 2a58c7c to 26f6d4f Compare January 21, 2023 04:56
@hlovdal
Copy link
Contributor

hlovdal commented Jan 21, 2023

The failing builds are due to stale old references to plain inform_multiline as opposed to new @log.inform_multiline.

exe/arduino_ci.rb
362:    return inform_multiline("Wildcard architecture in library.properties, using configured platforms") do
373:    return inform_multiline("Default config, platforms matching architectures in library.properties") do
382:  inform_multiline("Configured platforms that match architectures in library.properties") do

@ianfixes
Copy link
Collaborator Author

ianfixes commented Jan 21, 2023

Yup, I'm just making a lot of local edits and pushing up stuff to my branch that (for now) I expect to have failures. Lots of areas being cleaned up! All the puts in the testing portion of that file need to be replaced with @log.iputs as well, which is in progress

@ianfixes ianfixes force-pushed the 2023-01-18_logging branch 3 times, most recently from 0f573b5 to b46e1c9 Compare January 24, 2023 02:43
@ianfixes ianfixes force-pushed the 2023-01-18_logging branch 2 times, most recently from 04afdf3 to 5d905ed Compare March 9, 2023 02:36
@ianfixes ianfixes merged commit 1fd5446 into Arduino-CI:master Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add support to report size of compiled sketch
2 participants