Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for nupkg assets id duplication #241

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

flatrow
Copy link

@flatrow flatrow commented May 20, 2020

Problem:
I upload full and delta nupkg files, only one is inserted because generated asset's ids are equal.
Proposed solution:
Include nupkg type in asset id.

I would like to discuss this solution because I don't have an experience with Sails.js and new to the project.
Also I have concerns about migration, not sure if we should or not update old records. And if server is run in container it's required to attach into and run migration up - it seems that migrations should be applied at container start.

@stale
Copy link

stale bot commented Jul 19, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jul 19, 2020
@stale stale bot closed this Jul 27, 2020
@b-zurg
Copy link

b-zurg commented Jul 28, 2020

Lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants