Issue75

[StefanKoenen]

Solves #75

[StefanKoenen]

@paulerickson
Build is failing, but I don't know what the issue is (looks like a dependency issue?), can you please explain so I can resolve the issue.

[paulerickson]

I don't know much about the Maven Enforcer plugin, but it sounds like it's complaining about an slf4j artifact version. Since this wasn't changed directly in pom.xml either in your change or mine, it may be a transitive dependency of something else that did change.

I can't tell the ancestry of your commits, but if you merged my PR first and the Blue Ocean PR second you may have accidentally resolved a conflict in favor of the older Blue Ocean changeset.

It's really hard for me to speak to the changes, since my PR is only taken from @ilushka85's work, with others' bugfixes added too. This is just going to get harder to juggle unless something gets merged!

[grfullerton]

@paulerickson @StefanKoenen looks like you guys have been pretty active with PRs recently. It doesn't look like @Argelbargel has been active recently, so it might make sense to pick someone's fork and try to consolidate the effort into one place. I can help out, although my Java skills are a bit rusty.

Also, this might be good to look through, since there has been previous discussion about getting this plugin merged with the gitlab-plugin. There's also a reference implementation for a git branch source plugin (tl;dr, heres the reference implementation)