Proof of concept: gh-64595 fix #37
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Quick'n dirty, rough solution to python#64595 |
erlend-aasland
commented
Jan 17, 2024
| @@ -2522,9 +2525,14 @@ def parse_file( | |||
| verify=verify, | |||
| filename=filename, | |||
| limited_capi=limited_capi) | |||
| cooked = clinic.parse(raw) | |||
| generated, cooked = clinic.parse(raw) | |||
There was a problem hiding this comment.
We need better naming here. cooked must go.
erlend-aasland
commented
Jan 17, 2024
Comment on lines
+6306
to
+6307
| verify=not ns.force, limited_capi=ns.limited_capi, | ||
| force=ns.force) |
There was a problem hiding this comment.
Feels silly that verify is always the opposite of force.
|
I don't think we want to do this; working around build system shortcomings by adding (another) hack in Argument Clinic is not the way to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: