Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improvements & refactors #15

Merged
merged 7 commits into from
Mar 21, 2024
Merged

Conversation

rmrt1n
Copy link
Member

@rmrt1n rmrt1n commented Mar 19, 2024

Closes: WORLD-965, WORLD-963

Overview

Minor improvements & refactors to improve code

Brief Changelog

  • use 4040 as default port
  • get cardinal namespace from env variable
  • refactor sheets to use zod

Note: WORLD-968 is changed to get namespace from /world, and will be done in a separate PR along with WORLD-976

Testing and Verifying

manually tested/verified

Copy link

coderabbitai bot commented Mar 19, 2024

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.


Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link
Member Author

rmrt1n commented Mar 19, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rmrt1n and the rest of your teammates on Graphite Graphite

@rmrt1n rmrt1n changed the title feat: use 4040 as the default cardinal port feat: improvements & refactors Mar 19, 2024
Copy link

github-actions bot commented Mar 19, 2024

Copy link

linear bot commented Mar 19, 2024

WORLD-917 Send messages to world engine

This is more complicated than sending queries. might take a while…

@rmrt1n rmrt1n force-pushed the ryan/world-917-send-message branch from b7f0e70 to 990faf2 Compare March 19, 2024 20:07
Base automatically changed from ryan/world-917-send-message to main March 19, 2024 20:13
@rmrt1n rmrt1n force-pushed the ryan/improvements-and-refactors branch from eb6fe70 to b7cc361 Compare March 19, 2024 20:13
Copy link

linear bot commented Mar 19, 2024

@rmrt1n rmrt1n marked this pull request as ready for review March 21, 2024 08:15
@rmrt1n
Copy link
Member Author

rmrt1n commented Mar 21, 2024

I'm force merging this as it's mostly refactors & lint error fixes. The namespace part will be handled in a different PR.

@rmrt1n rmrt1n merged commit 7c5f704 into main Mar 21, 2024
4 checks passed
@rmrt1n rmrt1n deleted the ryan/improvements-and-refactors branch March 21, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants