Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use fixed height for bottom bar #23

Merged
merged 2 commits into from
Apr 1, 2024

Conversation

rmrt1n
Copy link
Member

@rmrt1n rmrt1n commented Mar 31, 2024

Closes: WORLD-1013

Overview

Inconsistent bottom bar UI when collapsed in different screens. This is caused by react-resizable-panels using only percentage values instead of pixels.

Screenshots:
Before:
image

After:
image

Brief Changelog

  • Show fixed height "bar" when panel is collapsed. This element is separate from the original panel contents.

Testing and Verifying

manually tested/verified

Copy link

coderabbitai bot commented Mar 31, 2024

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link
Member Author

rmrt1n commented Mar 31, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rmrt1n and the rest of your teammates on Graphite Graphite

@rmrt1n rmrt1n requested a review from zulkhair March 31, 2024 11:16
@rmrt1n rmrt1n force-pushed the ryan/world-1013-ugly-bottom-bar branch from 3eb21ef to b3ba424 Compare March 31, 2024 11:17
@rmrt1n rmrt1n changed the title feat: fixed height bottom bar fix: use fixed height for bottom bar Mar 31, 2024
@rmrt1n rmrt1n marked this pull request as ready for review March 31, 2024 11:20
Copy link
Collaborator

zulkhair commented Apr 1, 2024

​_​Merge activity​_​

• ​​_​Apr 1, 3:42 AM EDT​_​​: @zulkhair started a stack merge that includes this pull request via Graphite.
• ​​_​Apr 1, 3:45 AM EDT​_​​: Graphite rebased this pull request as part of a merge.
edited-with-Axolo*** ​****Apr 1, 3:46 AM EDT**​: @zulkhair merged this pull request with Graphite.

@zulkhair zulkhair changed the base branch from ryan/world-962-receipt-error-handling to main April 1, 2024 07:43
@zulkhair zulkhair force-pushed the ryan/world-1013-ugly-bottom-bar branch from a119396 to 9c676a4 Compare April 1, 2024 07:45
@zulkhair zulkhair merged commit 4586fa8 into main Apr 1, 2024
1 check passed
@rmrt1n rmrt1n deleted the ryan/world-1013-ugly-bottom-bar branch April 4, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants