Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add edit/delete entity group sheet #8

Merged
merged 23 commits into from
Mar 4, 2024
Merged

feat: add edit/delete entity group sheet #8

merged 23 commits into from
Mar 4, 2024

Conversation

rmrt1n
Copy link
Member

@rmrt1n rmrt1n commented Mar 1, 2024 •
edited
Loading

Closes: WORLD-907

Overview

Addition to the previous PR. This one allows users to edit the names/components of entity groups, as well as delete them.

Screencast:

Screencast.from.2024-03-01.16-34-36.webm

Brief Changelog

  • added toast shadcn component
  • added EditEntityGroupSheet for edit/delete of entity groups
  • toast feedback after entity group CRUD operations

Testing and Verifying

manually tested/verified

rmrt1n added 21 commits February 29, 2024 18:04
@rmrt1n
feat: show messages/queries in sidebar
86159c1
@rmrt1n
fix: minor style fixes
614251e
@rmrt1n
feat: add shadcn sheet component
dc895e4
@rmrt1n
feat: add multi-select component for archetype sidebar
83b6ec0
@rmrt1n
feat: create base ui for archetype sheet (side drawer)
451fb17 
not functional atm
@rmrt1n
feat: show sample entity when user selects components
2b62598
@rmrt1n
feat: update debug endpoint to /query/debug/state
6829496
@rmrt1n
feat: add ts types for entity & component
77bc592
@rmrt1n
refactor: changed debug state payload structure
88cf5d0
@rmrt1n
refactor: moved all entity/component components to a single file
0f3be95
@rmrt1n
fix: archetype sheet still used the deleted entity-card.tsx
049aa80
@rmrt1n
feat: use fetched components in archetype-sheet & moved react-query o…
f637138 
…ptions to separate file
@rmrt1n
nit: more intuitive names
b204adc
@rmrt1n
feat: add archetypes to config-provider & wire archetype-sheet to add…
cc48244 
… to it
@rmrt1n
feat: filtered ui for archetypes in cards view
4f1fa86
@rmrt1n
refactor: replace tabscontent with manual component switching
173e6f1 
using tabscontent renders 2 * n-entities components, and since we're rerendering every 1s, this
might be expensive for large numbers of entities. we just have to change the entity renderers
when 'view' prop changes now.
@rmrt1n
chore: rename 'archetype' to 'entity group' to not confuse with world…
6764278 
…-engine's internal archetype
@rmrt1n
feat: add edit entity group sheet
ca7a179
@rmrt1n
feat: add toast feedback after create/edit entity group
1c1a333
@rmrt1n
refactor: better code organization
2175d51
@rmrt1n
feat: add delete entity group feature
fd2047c
@linear Linear
Copy link

linear bot commented Mar 1, 2024

WORLD-907 Add edit & remove entity-groups functionality

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Mar 1, 2024 •
edited
Loading

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

This was referenced Mar 1, 2024
Merged
Merged
@rmrt1n Graphite App
Copy link
Member Author

rmrt1n commented Mar 1, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rmrt1n and the rest of your teammates on Graphite Graphite

@rmrt1n rmrt1n mentioned this pull request Mar 1, 2024
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 1, 2024 •
edited
Loading

Build deployed to Vercel

🔍 Inspect: https://vercel.com/argus-labs/cardinal-editor/4JHBLhSzXwWuoaez8ckdaHP7kwJ3
🌐 Build: https://cardinal-editor-kttyv54gx-argus-labs.vercel.app

@rmrt1n rmrt1n requested a review from zulkhair March 1, 2024 09:37
@rmrt1n rmrt1n marked this pull request as ready for review March 1, 2024 09:38
@rmrt1n rmrt1n changed the title feat: add edit entity group sheet feat: add edit/delete entity group sheet Mar 1, 2024
@rmrt1n rmrt1n mentioned this pull request Mar 1, 2024
Merged
zulkhair
zulkhair approved these changes Mar 4, 2024
View reviewed changes
Copy link
Collaborator

@zulkhair zulkhair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to plan how can we save/load different configuration :
https://linear.app/arguslabs/issue/WORLD-918/saveload-ce-configuration

Base automatically changed from ryan/world-852-add-archetype to ryan/world-887-point-to-new-endpoint March 4, 2024 08:57
@rmrt1n rmrt1n merged commit 9794d71 into ryan/world-887-point-to-new-endpoint Mar 4, 2024
4 checks passed
@rmrt1n rmrt1n deleted the ryan/world-907-edit-remove-entity-groups branch March 4, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zulkhair zulkhair zulkhair approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rmrt1n @zulkhair