fix: forgot password request with non existing email now returns a fo…

…rm request validator error
ArielMejiaDev · Oct 13, 2021 · 80c33ac · 80c33ac
1 parent 7453453
commit 80c33ac
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 11 deletions.
diff --git a/.idea/json-api-auth.iml b/.idea/json-api-auth.iml
diff --git a/.idea/php.xml b/.idea/php.xml
diff --git a/stubs/App/Http/Controllers/JsonApiAuth/PasswordResetLinkController.php b/stubs/App/Http/Controllers/JsonApiAuth/PasswordResetLinkController.php
@@ -13,7 +13,6 @@ class PasswordResetLinkController
 {
     public function __invoke(PasswordResetLinkRequest $request): JsonResponse
     {
-        /** @var User $user */
         $user = $request->getUser();
         $token = Str::random(60);
 

diff --git a/stubs/App/Http/Requests/JsonApiAuth/PasswordResetLinkRequest.php b/stubs/App/Http/Requests/JsonApiAuth/PasswordResetLinkRequest.php
@@ -4,6 +4,7 @@
 
 use App\Models\User;
 use Illuminate\Foundation\Http\FormRequest;
+use Illuminate\Validation\Rule;
 
 class PasswordResetLinkRequest extends FormRequest
 {
@@ -12,7 +13,7 @@ class PasswordResetLinkRequest extends FormRequest
      *
      * @return bool
      */
-    public function authorize()
+    public function authorize(): bool
     {
         return true;
     }
@@ -22,23 +23,17 @@ public function authorize()
      *
      * @return array
      */
-    public function rules()
+    public function rules(): array
     {
         return [
-            'email' => 'required|email',
+            'email' => ['required', 'email', Rule::exists(User::class)],
         ];
     }
 
     public function getUser()
     {
         $email = $this->get('email');
 
-        if(User::where('email', $email)->doesntExist()) {
-            return response()->json([
-                'message' => 'User does not exists',
-            ], 404);
-        }
-
-        return User::whereEmail($email)->first();
+        return User::query()->where('email', $email)->first();
     }
 }