Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GENERAL discussion, feedback, questions belong here! (v15) #452

Closed
Aris-t2 opened this issue Feb 13, 2022 · 41 comments
Closed

GENERAL discussion, feedback, questions belong here! (v15) #452

Aris-t2 opened this issue Feb 13, 2022 · 41 comments

Comments

@Aris-t2
Copy link
Owner

Aris-t2 commented Feb 13, 2022

Make sure you have updated your configuration to the most recent version of this projects files and are using the latest version of the "options" required by your Firefox version >before< reporting problems!

Continued from #3, #41, #88, #109, #133, #163, #189, #211, #241, #273, #308, #368, #404 and #417

Instead of opening new "issues" for general talk we can use this area for discussions, feedback and questions. Open new "issues" for real bugs and problems.

Custom JS scripts to restore more classic features
https://github.com/Aris-t2/CustomJSforFx

Things this project will not target/recreate

  • a CTR like plugin/application to generate ready-to-use CSS
  • curved tabs (thanks those are finally gone!)
  • old complete themes

Things not possible with CSS

  • more toolbars like add-on/status bar (CSS can not create new toolbars)
    • displaying full sized status popup below window content is possible
    • bookmarks toolbar at windows bottom is possible (simulated addon-bar)
  • new buttons (CSS can not create new buttons)
  • additional menuitems (CSS can not create new items)
  • custom/new/different functions for buttons/menuitems/menus
  • activity indicator (see 'custom JS scripts')
  • preference/options window
  • additional location bar
  • favicon in location bars identity box (see 'custom JS scripts')
  • moving menubar items to a different toolbar
  • restart button (see 'custom JS scripts')
  • ... many more
@mzso
Copy link

mzso commented Feb 13, 2022

@Aris-t2

@mzso
Tried to remove the jumping for ac_popup_megabar_title_and_url_two_lines.css in latest dev build.

addons_manager_alternative_appearance_compact_categories.css caused the glich in add-ons manager.

I installed 4.1.5. So what happens now is that the URLbar items don't jump, however with the huge handicap of the URL not being shown when I press alt, the switch to tab text remains.

The addon manage got worse by the categories not appearing at all, only the very left side of the highlights:
kép

Is this not meant to be compatible with FF97?

@Aris-t2
Copy link
Owner Author

Aris-t2 commented Feb 13, 2022

Get v4.1.5v2. Initial release only works, if "alternative appearance" for add-ons manager is active.

Switch tab item:
Hiding the url stops jumping.
Hiding the switch to tab item did not work as expected.

@mzso
Copy link

mzso commented Feb 14, 2022

@Aris-t2
Not sure if it's a good trade-off then. The URL is actually useful. And without it appearing, there's no indication that the item won't be switching tabs.

@BoomerangAide
Copy link

BoomerangAide commented Feb 14, 2022

Installed CSS 4.1.5v2, and found a bug: in the "about" window, the button to download a new version is displayed with a black background when it should be gray, possibly a weird hardcoded use of the dark theme I'm not using?
Seen on 96.0.3 (that's the version of my portable version for testing)


On another note, I (apparently so far) currently managed to kill animations and other nonsense of my ie6 download button with the following code:

/* Prevent download button from turning into something else */

#downloads-button[progress] > .toolbarbutton-badge-stack > #downloads-indicator-anchor > #downloads-indicator-icon,
#downloads-button[animate][notification] > .toolbarbutton-badge-stack > #downloads-indicator-anchor > #downloads-indicator-icon {
  visibility: visible !important;
}

#downloads-button > .toolbarbutton-badge-stack > .toolbarbutton-animatable-box {
	display:none !important;
}
/**/

Now I'm gonna see if there are some things I can remove from all that, but I wanted to share it as is, in the case I break it and can't find how to repair it 😛
edit: removed lots of stuff that ended up not being useful lol


On yet another note, after installing the aforementioned new CSS, I noticed something annoying, but in this case it may just be me not noticing it during my previous test with an older CSS version: a "Firefox suggère" (probably "Firefox suggest") element that was adding itself to my autosuggests from the url bar, getting in the way of the compactness I set up.
I managed to kill it with the following:

/* Remove "Firefox suggère" text in autocomplete */
.urlbarView-row[label]::before {
	content: none !important;
}

.urlbarView-row[label] {
	margin-block-start: unset !important;
}
/**/

Maybe it will help of help to someone

@Aris-t2
Copy link
Owner Author

Aris-t2 commented Feb 14, 2022

@mzso
I will look for a better solution.

@BoomerangAide

Installed CSS 4.1.5v2, and found a bug: in the "about" window, the button to download a new version is displayed with a black background when it should be gray, possibly a weird hardcoded use of the dark theme I'm not using?
Seen on 96.0.3 (that's the version of my portable version for testing)

This happens without any custom code for me too.

@nicolaasjan
Copy link

nicolaasjan commented Feb 14, 2022

Firefox 97.0, Linux; CustomCSSforFx 4.1.5

I use : @import "./css/generalui/context_bfrsb_icons_colorized.css".
But now there is no padding between the colorized icons and text...:
screenshot1

@Aris-t2
Copy link
Owner Author

Aris-t2 commented Feb 14, 2022

Sounds like the Linux code is not applied properly after recent changes:

Does this work:

@media (-moz-platform: linux) {

  :is(#context-back,#context-forward,#context-reload,#context-stop,#context-bookmarkpage) image {
	margin: 0 !important;
	width: 16px !important;
	height: 16px !important;
  }

  :is(#context-back,#context-forward,#context-reload,#context-stop,#context-bookmarkpage):after {
	margin-inline-start: 6px !important;
  }

}

or just this:

  :is(#context-back,#context-forward,#context-reload,#context-stop,#context-bookmarkpage) image {
	margin: 0 !important;
	width: 16px !important;
	height: 16px !important;
  }

  :is(#context-back,#context-forward,#context-reload,#context-stop,#context-bookmarkpage):after {
	margin-inline-start: 6px !important;
  }

@nicolaasjan
Copy link

Sounds like the Linux code is not applied properly after recent changes:

Does this work:

@media (-moz-platform: linux) {

  :is(#context-back,#context-forward,#context-reload,#context-stop,#context-bookmarkpage) image {
	margin: 0 !important;
	width: 16px !important;
	height: 16px !important;
  }

  :is(#context-back,#context-forward,#context-reload,#context-stop,#context-bookmarkpage):after {
	margin-inline-start: 6px !important;
  }

}

or just this:

  :is(#context-back,#context-forward,#context-reload,#context-stop,#context-bookmarkpage) image {
	margin: 0 !important;
	width: 16px !important;
	height: 16px !important;
  }

  :is(#context-back,#context-forward,#context-reload,#context-stop,#context-bookmarkpage):after {
	margin-inline-start: 6px !important;
  }

Thanks!
The second snippet worked. 🙂
Minor annoyance; for my old eyes, the contrast of these icons with dark theme could be better. ;)

@Aris-t2
Copy link
Owner Author

Aris-t2 commented Feb 14, 2022

@nicolaasjan

Could you test 4.1.5v3?
Recent Fx99+ compatibility changes broke the code I previously added for Linux.

@mzso
Copy link

mzso commented Feb 14, 2022

@Aris-t2 commented on 2022. febr. 13. 21:49 CET:

Get v4.1.5v2. Initial release only works, if "alternative appearance" for add-ons manager is active.

Switch tab item:
Hiding the url stops jumping.
Hiding the switch to tab item did not work as expected.

Doesn't seem to be different in 4.1.5v3. I don't think I ever used either of the alternative appearance options, but it worked fine. (Only the highlight started failing a bit as I showed before.)
I kind of prefer the icon+text categories of the unaltered appearance. I just set it to be compact and use buttons.

@Aris-t2
Copy link
Owner Author

Aris-t2 commented Feb 14, 2022

Firefox 97.0, Linux; CustomCSSforFx 4.1.5

I use : @import "./css/generalui/context_bfrsb_icons_colorized.css". But now there is no padding between the colorized icons and text...: screenshot1

v4.1.5v4 offers icon colors for dark theme consistent with other icon options like main toolbar icon colors and appmenu icon colors.

@mzso
The compact categories option supposed to show icons, if enabled, but previous changes did hide them. The glitch was present on your screenshot, so I took care of it (at least in my tests.)

@mzso
Copy link

mzso commented Feb 14, 2022

@Aris-t2

The compact categories option supposed to show icons, if enabled, but previous changes did hide them.

I don't get it. It was shown, along with category names, as shown by my image:https://user-images.githubusercontent.com/4479090/153457524-800ecda8-27eb-4b23-9a43-49c1fab463b8.png
The glitch was with only the highlight. Then both got hidden. But ironically the glitchy highlight remains.

@Aris-t2
Copy link
Owner Author

Aris-t2 commented Feb 14, 2022

The fix was for case 2, it was broken for me. Now it is working as expected.

  1. default view
    image

  2. default view + addons_manager_alternative_appearance_compact_categories.css
    image

  3. addons_manager_alternative_appearance.css
    image

  4. addons_manager_alternative_appearance.css + addons_manager_alternative_appearance_compact_categories.css
    image

@nicolaasjan
Copy link

v4.1.5v4 offers icon colors for dark theme consistent with other icon options like main toolbar icon colors and appmenu icon colors.

Thanks! 😀️
Have I applied it right here?

screenshot1

@Aris-t2
Copy link
Owner Author

Aris-t2 commented Feb 15, 2022

Did you also update the other files?

context_bfrsb_icons_colorized.css works fine, but context_bfrsb_labels_with_icons.css does not, when I look at your screenshot.

I only ran a quick test on Ubuntu, where the icon size and spaces matched other icons in context menu.

@nicolaasjan
Copy link

Did you also update the other files?

context_bfrsb_icons_colorized.css works fine, but context_bfrsb_labels_with_icons.css does not, when I look at your screenshot.

I only ran a quick test on Ubuntu, where the icon size and spaces matched other icons in context menu.

@import "./css/generalui/context_bfrsb_labels_with_icons.css" is uncommented here...

screenshot1

@Aris-t2
Copy link
Owner Author

Aris-t2 commented Feb 15, 2022

image

I get this with current 1.4.5v5.

@nicolaasjan
Copy link

I don't see any difference with the current 1.4.5v5...

screenshot1

@Aris-t2
Copy link
Owner Author

Aris-t2 commented Feb 15, 2022

Either newest context_bfrsb_labels_with_icons.css is not applied correctly or this does not work for you.
No idea why.

@nicolaasjan
Copy link

Either newest context_bfrsb_labels_with_icons.css is not applied correctly or this does not work for you. No idea why.

Well, I can live with it for now. 🙂
Btw, this is on Linux Mint MATE 20.3

@Aris-t2
Copy link
Owner Author

Aris-t2 commented Feb 15, 2022

Not sure why Linux Mint Mate would behave differently for you, but I just tested it in a VM getting same results Ubuntu (incl. KUbuntu & XUbuntu) offers. ( Yes I have many VMs ;-) )

image

image

@nicolaasjan
Copy link

👍️
Btw, Virtualbox is already at 6.1.32
I use Firefox from the official Mozilla tarball.

@Achille-Grs
Copy link

Hi @Aris-t2 !! I'm trying to make my own menu bar with some effects and I need the ID menu names for:
• File • Edit • View • History • Bookmarks • Tools • Help
Is that easy for you?
Thank you!!!!!

@BoomerangAide
Copy link

I was wondering about the changes in v5 with all those changes related to moz-os-version, and tried to search firefox source (after searching FOR firefox source for a while 🤣 ), and ran into something that maybe will be useful/relevant in the future:
https://hg.mozilla.org/mozilla-central/rev/2b9a5979a66e3f68ae1dbf9e1d1ab4f11973d4c2

@Aris-t2
Copy link
Owner Author

Aris-t2 commented Feb 26, 2022

@Achille-Grs

image

@BoomerangAide
I used the info and rules from there.

The tricky part was keeping code for Fx99+ and pre-99 inside the same css files without causing Fx99+ code to break pre-99 code and vice versa and of course work cross platform.

Each time I fixed one case, I created an issue somewhere else ;-)

@LoneCrusader2002
Copy link

Is there still a way to restore the "history dropmarker" in the Location Bar / URLBar or has Mozilla broken it? I don't see any options for it in userChrome.css...

Also, is there a way to hide the Tab bar when only one tab is open? I experimented with this, but it proceeded to hide my Menu bar instead. Also found this, but haven't experimented with it...

@Achille-Grs
Copy link

Achille-Grs commented Feb 28, 2022

Hi @Aris-t2 !! Finaly I made something defferent for "toolbar-menubar". With your help I added simple decorative Icons in front of the text Pic 1.
I made another one too, but only icons in the center of the "toolbar-menubar" with hovering effect Pic 2 and as you can see,
the menu opensand works fine Pic 3.
Maybe it's nothing great, but it's an effort.
If someone likes it and wants to use it, they can download it from here: https://we.tl/t-6pmyiLj1TZ
Screenshot 2022-02-28 195449

@KenshiTakahashi
Copy link

Hello. Tell me, is it possible to disable all these icons, and if so, how? It's not good for me to just turn on notifications, I need to turn off these icons completely
08 03 22 - 15 36
.

@Achille-Grs
Copy link

@KenshiTakahashi

#tracking-protection-icon-container,
.identity-box-button,
#tracking-protection-icon-box,
#tracking-protection-icon {
display: none !important;
}

@KenshiTakahashi
Copy link

@Achille-Grs Wow. Many thanks!

@Crybal
Copy link

Crybal commented Mar 9, 2022

Could someone please tell me how to change the text color (username/password) of the about:logins page? When I have a light theme they are white so nothing appears in these fields.Thanks

@Achille-Grs
Copy link

@Crybal Can you upload a screenshot?

@Thalon77
Copy link

Thalon77 commented Mar 10, 2022

A bit of an OT question but considering that this space is followed by many tinkerers who like to customize Firefox I have a question not related to the CSS "per se" but related to the general customization aimed to keep the old appearance and behavior.
FF V98 just came out and the foundation decided that the old downloads behaviour wasn't good enough and needed some upgrade: the result is that now you can't directly open some files without downloading them (eg: I click on a magnet link to start a torrent, I can tell Firefox to automatically let my torrent client to open it but then I always find the *.torrent file inside my download directory),
I need to try to revert the things how they were before V98 (without copies of the files I automatically open cluttering my download dir): is there a way to do so (maybe some hidden command in about: config)? Has anybody here tried to change that?

EDIT: managed to find an answer, so problem solved, I leave the solution here for others: you have to set "browser.download.improvements_to_download_panel" in about:config to false, maybe this fix could be added to that FAQ here with the other config tweaks.

@Crybal
Copy link

Crybal commented Mar 10, 2022

@Crybal Can you upload a screenshot?

Sorry,my mistake.A css was activated that changed the logins page to an alternative appearance.I finally found it,disabled and now it looks OK.

@ImSpecial
Copy link

Need some help here, recently this add-on got updated and added a new context menu...

https://i.imgur.com/RMeyP4N.png

"Copy target URL"

I cannot for the life of me get the menu item ID to hide it, it won't stay open when I try to inspect it, can someone help me out here?

What's needed to hide this.

Add-on in question;

https://addons.mozilla.org/en-US/firefox/addon/skip-redirect/?utm_content=addons-manager-reviews-link&utm_medium=firefox-browser&utm_source=firefox-browser

@Aris-t2
Copy link
Owner Author

Aris-t2 commented Mar 12, 2022

@ImSpecial

#skipredirect_sblask-menuitem-_copy-target-url

You can force most popups to stay open for inspection by enabling Disable Popup Auto-Hide:

image

@ImSpecial
Copy link

Thanks Aris that works perfect! And I could have sworn I did have that option checked... I'm usually pretty good with finding ID's but this one, any time I moved my mouse or alt+TAB after finding it, to the inspector, things would shift.

@Yaron10
Copy link

Yaron10 commented Mar 12, 2022

Hello @Aris-t2,

Firefox 98: content instead of list-style-image.

.tab-icon-image { opacity: 1 !important; }
.tab-icon-image:not([busy], [src]) { content: url("DefaultFavicon.png") !important; display: inline !important; }

@NotoIsBest
Copy link

NotoIsBest commented Mar 13, 2022

Hello, I'd like to report a bug - in icons_custom_icons_fx1.css, the reference for the toolbar .png is missing, and all buttons become blank. What's missing is this: list-style-image: url("../../image/toolbar_fx1.png") !important; in the 19th line. Readding it manually fixes the problem.

@Thalon77
Copy link

Need to report that the "restore empty/missing tab favicon" tabs setting doesn't seem to work after updating FF to V98, every change to that results always in the same default globe icon.

@Aris-t2
Copy link
Owner Author

Aris-t2 commented Mar 18, 2022

Repository owner locked and limited conversation to collaborators Mar 18, 2022
@Aris-t2 Aris-t2 converted this issue into discussion #454 Mar 18, 2022
@Aris-t2 Aris-t2 unpinned this issue Mar 18, 2022
@Aris-t2 Aris-t2 pinned this issue Mar 18, 2022
@Aris-t2 Aris-t2 unpinned this issue Mar 18, 2022

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Projects
None yet
Development

No branches or pull requests