Properly Handle Custom Http Endpoints #15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current version,
should_use_http
only returnstrue
iff the endpoint url is in theEndpoints
enum.The
register_otel
function, however, accepts custom hosts as a string:So, if you call
register_otel
with an endpoint that is not in theEndpoints
enum, (say,http://localhost:7000
), thenshould_use_http
will returnfalse
, even if the user intends to send things over http.This pull request adjusts
should_use_http
to consider strings as input types.