feat: add session.id and user.id semantic conventions #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:S
mikeldking
approved these changes
Apr 5, 2024
| @@ -55,5 +55,7 @@ The following attributes are reserved and MUST be supported by all OpenInference | |||
| | `reranker.top_k` | Integer | 3 | Top K parameter of the reranker | | |||
| | `tag.tags` | List of strings | ["shopping", "travel"] | List of tags to give the span a category | | |||
| | `metadata` | JSON String | `"{'author': 'John Doe', 'date': '2023-09-09'}"` | Metadata associated with a span | | |||
| | `session.id` | String/Integer | `"session-123"` or `123` | ID for a session | | |||
There was a problem hiding this comment.
is there a reason for allowing integer ids here too?
|
Closing this PR for now as we are de-prioritizing sessions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds
session.idanduser.idsemantic conventionsresolves Arize-ai/phoenix#2678