Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: ensure type ignores in langchain tests run across all versions of langchain #460

Merged
merged 2 commits into from
May 14, 2024
Merged

ci: ensure type ignores in langchain tests run across all versions of langchain #460

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1682fca
fix: remove unused type ignores from langchain tests
axiomofjoy May 14, 2024
341c190
cover all versions
axiomofjoy May 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ...trumentation-langchain/tests/openinference/instrumentation/langchain/test_instrumentor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -533,9 +533,9 @@ def test_chain_metadata(
# We will test that these variables do not overwrite the passed variables
prompt_template_variables=prompt_template_variables,
):
llm.predict(**langchain_prompt_variables) # type: ignore
llm.predict(**langchain_prompt_variables)
else:
llm.predict(**langchain_prompt_variables) # type: ignore
llm.predict(**langchain_prompt_variables)
spans = in_memory_span_exporter.get_finished_spans()
spans_by_name = {span.name: span for span in spans}

Expand Down Expand Up @@ -658,9 +658,9 @@ def test_read_session_from_metadata(
# We will test that these variables do not overwrite the passed variables
prompt_template_variables=prompt_template_variables,
):
llm.predict(**langchain_prompt_variables) # type: ignore
llm.predict(**langchain_prompt_variables)
else:
llm.predict(**langchain_prompt_variables) # type: ignore
llm.predict(**langchain_prompt_variables)
spans = in_memory_span_exporter.get_finished_spans()
spans_by_name = {span.name: span for span in spans}

Expand Down
Loading