chore: update pnpm version and pin in package.json #946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XS
mikeldking
reviewed
Aug 22, 2024
| @@ -26,7 +26,7 @@ jobs: | |||
| - name: Setup PNPM | |||
| uses: pnpm/action-setup@v4 | |||
| with: | |||
| version: 8 | |||
| version: 9.8.0 | |||
There was a problem hiding this comment.
this has to be specified?
There was a problem hiding this comment.
it doesnt have to specify the fullpath but figured we might as well keep it in sync with whats in pacakge.json, which does have to specify the whole path
mikeldking
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/pnpm/pnpm/releases/tag/v9.7.0
pnpm/pnpm#8363
In order for the packageManger field to be picked up global pnpm must be >=9.7.0.
After that when you're in the js directory any pnpm commands will use the version specified in package json