Skip to content

Commit

Permalink
Merge pull request #30 from Arize-ai/polish-notebook
Browse files Browse the repository at this point in the history
chore: rename project
  • Loading branch information
mikeldking authored Nov 18, 2022
2 parents f7318e2 + a9635ff commit 343deb4
Show file tree
Hide file tree
Showing 15 changed files with 62 additions and 63 deletions.
101 changes: 50 additions & 51 deletions .github/workflows/python-CI.yml
Original file line number Diff line number Diff line change
@@ -1,61 +1,60 @@
name: Python CI

on:
pull_request:
paths:
- "**.py"
pull_request:
paths:
- "**.py"

jobs:
# Error: Dependency review is not supported on this repository. Please ensure that Dependency graph is enabled,
# see https://github.com/Arize-ai/arize-toolbox/settings/security_analysis
#
# dep-review:
# name: Dependency Review
# runs-on: ubuntu-latest
# permissions:
# contents: read
# steps:
# - name: Check out Git repository
# uses: actions/checkout@v3
# - name: Dependency Review
# uses: actions/dependency-review-action@v1

# TODO(Kiko): Improve this GitHub Action
# documentation:
# name: Docstring Coverage
# runs-on: ubuntu-latest
# steps:
# - name: Checkout
# uses: actions/checkout@v3
# - name: Set up Python 3.8
# uses: actions/setup-python@v3
# with:
# python-version: 3.8
# - name: Python Interrogate Check
# uses: JackMcKew/python-interrogate-check@main
# with:
# path: 'arize_toolbox'
# fail-under: 90
# Error: Dependency review is not supported on this repository. Please ensure that Dependency graph is enabled,
# see https://github.com/Arize-ai/arize-toolbox/settings/security_analysis
#
# dep-review:
# name: Dependency Review
# runs-on: ubuntu-latest
# permissions:
# contents: read
# steps:
# - name: Check out Git repository
# uses: actions/checkout@v3
# - name: Dependency Review
# uses: actions/dependency-review-action@v1

code-format:
name: Code Format
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v3
- uses: ricardochaves/python-lint@v1.4.0
with:
python-root-list: "."
use-pylint: false
use-pycodestyle: false
use-mypy: false
use-flake8: true
use-isort: true
use-black: true
extra-flake8-options: "--max-line-length=94 --exclude=__init__.py"
extra-black-options: "--check --diff --color"
extra-isort-options: "--profile black --check-only --diff"
# TODO(Kiko): Improve this GitHub Action
# documentation:
# name: Docstring Coverage
# runs-on: ubuntu-latest
# steps:
# - name: Checkout
# uses: actions/checkout@v3
# - name: Set up Python 3.8
# uses: actions/setup-python@v3
# with:
# python-version: 3.8
# - name: Python Interrogate Check
# uses: JackMcKew/python-interrogate-check@main
# with:
# path: 'phoenix'
# fail-under: 90

code-format:
name: Code Format
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v3
- uses: ricardochaves/python-lint@v1.4.0
with:
python-root-list: "."
use-pylint: false
use-pycodestyle: false
use-mypy: false
use-flake8: true
use-isort: true
use-black: true
extra-flake8-options: "--max-line-length=94 --exclude=__init__.py"
extra-black-options: "--check --diff --color"
extra-isort-options: "--profile black --check-only --diff"
# Error: Advanced Security must be enabled for this repository to use code scanning.
#
# code-ql:
Expand Down
1 change: 0 additions & 1 deletion arize_toolbox/widgets/__init__.py

This file was deleted.

2 changes: 1 addition & 1 deletion index.html
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<head>
<meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>App</title>
<script src="./arize_toolbox/nbextension/static/index.js"></script>
<script src="./phoenix/nbextension/static/index.js"></script>
</head>
<body>
<div id="root"></div>
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,6 @@
"typescript": "^4.8.4"
},
"scripts": {
"build": "esbuild ui/src/index.tsx --bundle --minify --target=es2020 --format=esm --outfile=arize_toolbox/nbextension/static/index.js"
"build": "esbuild ui/src/index.tsx --bundle --minify --target=es2020 --format=esm --outfile=phoenix/nbextension/static/index.js"
}
}
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.

Large diffs are not rendered by default.

File renamed without changes.
File renamed without changes.
1 change: 1 addition & 0 deletions phoenix/widgets/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
from .umapWidget import UMAPWidget, demo_json
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@

from IPython.core.display import HTML, display # type: ignore

import arize_toolbox
import phoenix

BASE_PATH = arize_toolbox.__path__[0] # type: ignore
BASE_PATH = phoenix.__path__[0] # type: ignore
STATIC_PATH = os.path.join(BASE_PATH, "nbextension", "static")

"""Loads the compiled Javascript bundle"""
Expand Down Expand Up @@ -40,8 +40,8 @@ def demo_json():


class UMAPWidget:
def __init__(self, to_json=demo_json):
self.to_json = to_json
def __init__(self, json: str):
self.json = json

def template(self, json_data: str):
return f"""
Expand All @@ -58,4 +58,4 @@ def template(self, json_data: str):
# Temporary static json representation of UMAP Drift data

def show(self):
display(HTML(self.template(self.to_json())))
display(HTML(self.template(self.json)))
4 changes: 2 additions & 2 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,10 @@ dependencies = ["hatch-jupyter-builder"]
build-function = "hatch_jupyter_builder.npm_builder"

[hatch_jupyter_builder.utils.npm_builder]
build_dir = "/arize_toolbox/nbextension/static"
build_dir = "/phoenix/nbextension/static"

[tool.hatch.version]

[project]
name = "arize_toolbox"
name = "phoenix"
version = "0.0.1"
2 changes: 1 addition & 1 deletion ui/src/components/canvas/DriftPointCloud.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export function DriftPointCloud({
referenceData,
}: DriftPointCloudProps) {
return (
<div>
<div style={{ height: 600 }}>
<ErrorBoundary>
<ThreeDimensionalCanvas camera={{ position: [0, 0, 10] }}>
<ThreeDimensionalControls />
Expand Down

0 comments on commit 343deb4

Please sign in to comment.