Skip to content

Commit

Permalink
ci: build frontend in release pipeline (#1644)
Browse files Browse the repository at this point in the history
  • Loading branch information
axiomofjoy authored Oct 19, 2023
1 parent e6a3036 commit 8e471fe
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 59 deletions.
61 changes: 13 additions & 48 deletions .github/workflows/publish-to-pypi.yml
Original file line number Diff line number Diff line change
@@ -1,36 +1,36 @@
name: Publish Python 🐍 distribution 📦 to PyPI
name: Publish to PyPI

on: push

jobs:
build:
name: Build distribution 📦
name: Build distribution
if: startsWith(github.ref, 'refs/tags/') # only publish to PyPI on tag pushes
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v4
- name: Set up Python
uses: actions/setup-python@v4
with:
python-version: "3.x"
- name: Install pypa/build
run: >-
python3 -m
pip install
build
--user
- name: Set up node
uses: actions/setup-node@v3
- name: Build frontend
run: cd app && rm -rf node_modules && npm install && npm run build
- name: Install hatch
run: |
python -m pip install --upgrade pip
pip install hatch
- name: Build a binary wheel and a source tarball
run: python3 -m build
run: rm -rf dist && hatch build
- name: Store the distribution packages
uses: actions/upload-artifact@v3
with:
name: python-package-distributions
path: dist/

publish-to-pypi:
name: >-
Publish Python 🐍 distribution 📦 to PyPI
if: startsWith(github.ref, 'refs/tags/') # only publish to PyPI on tag pushes
name: Publish to PyPI
needs:
- build
runs-on: ubuntu-latest
Expand All @@ -47,38 +47,3 @@ jobs:
path: dist/
- name: Publish distribution 📦 to PyPI
uses: pypa/gh-action-pypi-publish@release/v1

github-release:
name: >-
Sign the Python 🐍 distribution 📦 with Sigstore
and upload them to GitHub Release
needs:
- publish-to-pypi
runs-on: ubuntu-latest

permissions:
contents: write # IMPORTANT: mandatory for making GitHub Releases
id-token: write # IMPORTANT: mandatory for sigstore

steps:
- name: Download all the dists
uses: actions/download-artifact@v3
with:
name: python-package-distributions
path: dist/
- name: Sign the dists with Sigstore
uses: sigstore/gh-action-sigstore-python@v1.2.3
with:
inputs: >-
./dist/*.tar.gz
./dist/*.whl
- name: Upload artifact signatures to GitHub Release
env:
GITHUB_TOKEN: ${{ github.token }}
# Upload to GitHub Release using the `gh` CLI.
# `dist/` contains the built packages, and the
# sigstore-produced signatures and certificates.
run: >-
gh release upload
'${{ github.ref_name }}' dist/**
--repo '${{ github.repository }}'
10 changes: 0 additions & 10 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -82,16 +82,6 @@ artifacts = ["src/phoenix/server/static"]
[tool.hatch.build]
only-packages = true

[tool.hatch.build.hooks.jupyter-builder]
dependencies = ["hatch-jupyter-builder"]
build-function = "hatch_jupyter_builder.npm_builder"
ensured-targets = ["src/phoenix/server/static/index.js"]
skip-if-exists = ["src/phoenix/server/static/index.js"]

[tool.hatch.build.hooks.jupyter-builder.build-kwargs]
path = "app"
source_dir = "app"

[tool.hatch.build.targets.sdist]
artifacts = ["src/phoenix/server/static"]

Expand Down
2 changes: 1 addition & 1 deletion src/phoenix/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
from .trace.fixtures import load_example_traces
from .trace.trace_dataset import TraceDataset

__version__ = "0.0.50rc"
__version__ = "0.0.50rc1"

# module level doc-string
__doc__ = """
Expand Down

0 comments on commit 8e471fe

Please sign in to comment.