-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Preserve the output of the eval notebooks #1559
Comments
If no one is working yet, I can try this. It's just all the existing notebooks from tutorials/evals/* which are required to preserve output in this PR, right? |
@pbadhe That would be great! Let me know if you want to chat on it. Feel free to assign the ticket to yourself. |
Exactly. We want to continue to scrub notebook metadata, but keep the output. And maybe do a sanity check to make sure our API keys stored in |
Thanks for assigning @mikeldking. @axiomofjoy I think I cannot change the assignee that's why didn't assign the issue to myself. |
The pre-commit still contains the wrong sanitization logic so I will re-open https://github.com/Arize-ai/phoenix/blob/main/.pre-commit-config.yaml |
Sorry, missed it. @mikeldking. |
No worries @pbadhe ! |
Good catch @mikeldking |
We would like to have eval notebooks that contain a clean output of the results without containing secret openAI keys in the metadata. The notebooks need to be a bit cleaner so it's not polluted with output.
Acceptance criteria
The text was updated successfully, but these errors were encountered: