docs: Preserve output, clean eval notebooks

[pbadhe]

Resolves #1559

• Output

• Removed metadata and execution count

[review-notebook-app]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[axiomofjoy]

Hey @pbadhe, thanks for picking up this ticket. In addition to executing the notebooks to include input, we also need to alter the hatch notebook command for cleaning the notebook to exclude notebooks inside the evals directory.

phoenix/pyproject.toml

Line 199 in 50e765b

clean = [

This command is causing the current pipeline failure:

phoenix/.github/workflows/python-CI.yml

Line 51 in 50e765b

- name: Check notebooks have cleaned output and metadata

[pbadhe]

Had to do this as I couldn't find a negation(!) wildcard (for all *.ipynb except evals/*) that works in both windows and unix at the same time, apart from writing a new py script and then calling it in here.

[axiomofjoy]

Is there a shell command that works?

[pbadhe]

This one does find . -name "*.ipynb" -not -path "./tutorials/evals/*" -exec jupyter nbconvert --ClearOutputPreprocessor.enabled=True --ClearMetadataPreprocessor.enabled=True --inplace {} \;

[axiomofjoy]

Looks good.

[mikeldking]

We missed the pre-commit hook (which I think is sorta a problem that we have two checks). Will reopen the ticket