Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Preserve output, clean eval notebooks #1590

Merged
merged 6 commits into from
Oct 13, 2023
Merged

docs: Preserve output, clean eval notebooks #1590

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7321de7
+ Output - Removed metadata and execution count
pbadhe Oct 9, 2023
a250be7
Merge branch 'main' into evalNotebooks
pbadhe Oct 11, 2023
5f83661
Merge branch 'main' into evalNotebooks
pbadhe Oct 12, 2023
ab91d5b
Outputs & nbconvert temporary fix
pbadhe Oct 12, 2023
4a937b0
Merge branch 'main' into evalNotebooks
axiomofjoy Oct 13, 2023
d6a4534
Merge branch 'main' into evalNotebooks
mikeldking Oct 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ fix = [

[tool.hatch.envs.notebooks.scripts]
clean = [
"jupyter nbconvert --ClearOutputPreprocessor.enabled=True --ClearMetadataPreprocessor.enabled=True --inplace **/*.ipynb **/**/*.ipynb",
"jupyter nbconvert --ClearOutputPreprocessor.enabled=True --ClearMetadataPreprocessor.enabled=True --inplace **/*.ipynb **/internal/*.ipynb **/tracing/*.ipynb **/dolly-pythia-fine-tuned/*.ipynb",
Copy link
Collaborator Author

@pbadhe pbadhe Oct 12, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to do this as I couldn't find a negation(!) wildcard (for all *.ipynb except evals/*) that works in both windows and unix at the same time, apart from writing a new py script and then calling it in here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a shell command that works?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one does find . -name "*.ipynb" -not -path "./tutorials/evals/*" -exec jupyter nbconvert --ClearOutputPreprocessor.enabled=True --ClearMetadataPreprocessor.enabled=True --inplace {} \;

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

]

[tool.hatch.envs.publish]
Expand Down
588 changes: 539 additions & 49 deletions tutorials/evals/evaluate_QA_classifications.ipynb
View file
Open in desktop

Large diffs are not rendered by default.

925 changes: 872 additions & 53 deletions tutorials/evals/evaluate_code_readability_classifications.ipynb
View file
Open in desktop

Large diffs are not rendered by default.

532 changes: 491 additions & 41 deletions tutorials/evals/evaluate_hallucination_classifications.ipynb
View file
Open in desktop

Large diffs are not rendered by default.

574 changes: 532 additions & 42 deletions tutorials/evals/evaluate_relevance_classifications.ipynb
View file
Open in desktop

Large diffs are not rendered by default.

539 changes: 497 additions & 42 deletions tutorials/evals/evaluate_summarization_classifications.ipynb
View file
Open in desktop

Large diffs are not rendered by default.

534 changes: 493 additions & 41 deletions tutorials/evals/evaluate_toxicity_classifications.ipynb
View file
Open in desktop

Large diffs are not rendered by default.