feat: Deprecate datasets module, rename to inferences
#2785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XXL
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
RogerHYang
approved these changes
Apr 5, 2024
anticorrelator
changed the title
datasets module, rename to inferencesdatasets module, rename to inferences
axiomofjoy
reviewed
Apr 5, 2024
| @@ -2,8 +2,8 @@ | |||
|
|
|||
| import pytest | |||
| from pandas import DataFrame, Timestamp | |||
| from phoenix.datasets.dataset import Dataset as InternalDataset | |||
| from phoenix.datasets.dataset import Schema | |||
| from phoenix.inferences.inference import Inference as InternalDataset | |||
There was a problem hiding this comment.
Rename to InternalInference.
axiomofjoy
reviewed
Apr 5, 2024
| from phoenix.datasets.dataset import Dataset | ||
| from phoenix.datasets.schema import EmbeddingColumnNames, EmbeddingFeatures | ||
| from phoenix.inferences.inference import Inference | ||
| from phoenix.inferences.schema import EmbeddingColumnNames, EmbeddingFeatures | ||
|
|
||
| from .embedding_dimension import EmbeddingDimension | ||
|
|
||
|
|
||
| def _get_embedding_dimensions( |
There was a problem hiding this comment.
I think we can rename these arguments for clarity.
There was a problem hiding this comment.
I'm going to leave renames alone I think, this is a big refactor and I'm already having a tough time keeping it all straight
axiomofjoy
reviewed
Apr 5, 2024
| def _is_dataset(obj: Optional[Dataset]) -> TypeGuard[Dataset]: | ||
| return type(obj) is Dataset | ||
| def _is_dataset(obj: Optional[Inference]) -> TypeGuard[Inference]: | ||
| return type(obj) is Inference |
There was a problem hiding this comment.
These probably deserve to be renamed.
axiomofjoy
reviewed
Apr 5, 2024
| @@ -114,9 +114,9 @@ def _load_items( | |||
| trace_dataset_name: Optional[str] = None | |||
| simulate_streaming: Optional[bool] = None | |||
|
|
|||
| primary_dataset: Dataset = EMPTY_DATASET | |||
There was a problem hiding this comment.
Probably can be renamed.
axiomofjoy
reviewed
Apr 5, 2024
tests/datasets/test_inference.py
Outdated
| _normalize_timestamps, | ||
| _parse_dataframe_and_schema, | ||
| ) | ||
| from phoenix.datasets.errors import DatasetError | ||
| from phoenix.datasets.schema import ( | ||
| from phoenix.inferences.schema import ( |
There was a problem hiding this comment.
Looks like the test names in this file are still named with dataset names.
axiomofjoy
reviewed
Apr 5, 2024
Comment on lines
-37
to
+38
| primary_dataset: InternalDataset, | ||
| reference_dataset: InternalDataset, | ||
| primary_dataset: InternalInference, | ||
| reference_dataset: InternalInference, |
There was a problem hiding this comment.
looks like this file still has a lot of dataset names
axiomofjoy
reviewed
Apr 5, 2024
| NAME_TO_FIXTURE = {fixture.name: fixture for fixture in FIXTURES} | ||
|
|
||
|
|
||
| def get_datasets( |
axiomofjoy
reviewed
Apr 5, 2024
| no_internet: bool = False, | ||
| ) -> Tuple[Inference, Optional[Inference], Optional[Inference]]: | ||
| """ | ||
| Downloads primary and reference datasets for a fixture if they are not found |
axiomofjoy
reviewed
Apr 5, 2024
src/phoenix/inferences/inference.py
Outdated
| SchemaLike: TypeAlias = Any | ||
|
|
||
|
|
||
| class Inference: |
There was a problem hiding this comment.
Should this be plural because it represents multiple inferences?
axiomofjoy
approved these changes
Apr 5, 2024
mikeldking
requested changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2732
phoenix.datasetsmodule, interfaces are available underphoenix.inferencespx.Datasetclass renamed topx.Inferencepx.ExampleDatasetsclass renmaed topx.ExampleInferencesDatasets.from_open_inferencedeprecated and removed fromInference