-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Deprecate datasets
module, rename to inferences
#2785
Merged
Merged
Changes from 4 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
c445ffc
Initial refactor of Datasets -> Inferences
anticorrelator 9c29507
Add deprecation warnings to "datasets" public interface
anticorrelator 2196e30
Fix type signature
anticorrelator cca7e34
Ensure ExampleDatasets still exists
anticorrelator 4f8ca27
Use multiline string
anticorrelator 2ab294b
Rename test files
anticorrelator 07f39db
Remove test for `Inference.from_open_inference`
anticorrelator 69433b1
exclude manual instrumentation example from type checks
axiomofjoy 5698b32
Revert changes to notebooks
anticorrelator 6ea4102
Merge branch 'dustin/deprecate-datasets' of github.com:Arize-ai/phoen…
anticorrelator 1446a3f
Rename `Inference` -> `Inferences`
anticorrelator 7f91187
Fix line length
anticorrelator 2612b08
Merge remote-tracking branch 'origin' into dustin/deprecate-datasets
anticorrelator File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,18 +6,18 @@ | |
from pandas.api.types import is_object_dtype | ||
from typing_extensions import TypeAlias, TypeGuard | ||
|
||
from phoenix import Dataset, EmbeddingColumnNames | ||
from phoenix import EmbeddingColumnNames, Inference | ||
from phoenix.core.model import _get_embedding_dimensions | ||
from phoenix.core.model_schema import Embedding, Model, RetrievalEmbedding, Schema | ||
from phoenix.datasets.schema import RetrievalEmbeddingColumnNames | ||
from phoenix.datasets.schema import Schema as DatasetSchema | ||
from phoenix.inferences.schema import RetrievalEmbeddingColumnNames | ||
from phoenix.inferences.schema import Schema as DatasetSchema | ||
|
||
DatasetName: TypeAlias = str | ||
ColumnName: TypeAlias = str | ||
DisplayName: TypeAlias = str | ||
|
||
|
||
def create_model_from_datasets(*datasets: Optional[Dataset]) -> Model: | ||
def create_model_from_datasets(*datasets: Optional[Inference]) -> Model: | ||
# TODO: move this validation into model_schema.Model. | ||
if len(datasets) > 1 and datasets[0] is not None: | ||
# Check that for each embedding dimension all vectors | ||
|
@@ -132,8 +132,8 @@ def create_model_from_datasets(*datasets: Optional[Dataset]) -> Model: | |
) | ||
|
||
|
||
def _is_dataset(obj: Optional[Dataset]) -> TypeGuard[Dataset]: | ||
return type(obj) is Dataset | ||
def _is_dataset(obj: Optional[Inference]) -> TypeGuard[Inference]: | ||
return type(obj) is Inference | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These probably deserve to be renamed. |
||
|
||
|
||
def _take_first_str(iterator: Iterable[str]) -> str: | ||
|
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can rename these arguments for clarity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to leave renames alone I think, this is a big refactor and I'm already having a tough time keeping it all straight