feat(auth): create system key #4235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeldking
commented
Aug 15, 2024
| @@ -61,6 +61,7 @@ dependencies = [ | |||
| "arize-phoenix-evals>=0.13.1", | |||
| "fastapi", | |||
| "pydantic>=1.0,!=2.0.*,<3,", # exclude 2.0.* since it does not support the `json_encoders` configuration setting | |||
| "pyjwt", | |||
There was a problem hiding this comment.
@axiomofjoy not 100% sure on the authlib dependency yet and so just minimizing the dependencies for now. I think it's pretty interchangeable if needed.
dosubot
bot
added
the
size:L
axiomofjoy
reviewed
Aug 15, 2024
src/phoenix/server/app.py
Outdated
| secret (Optional[str], optional): The application secret for auth. Defaults to None. | ||
|
|
||
| Returns: | ||
| GraphQLRouter: _description_ |
axiomofjoy
reviewed
Aug 15, 2024
axiomofjoy
approved these changes
Aug 15, 2024
Comment on lines
+25
to
+27
| class CreateApiKeyInput: | ||
| name: str | ||
| description: Optional[str] = UNSET |
There was a problem hiding this comment.
We'll also need the expiry.
There was a problem hiding this comment.
Okay I can add that. I wasn't sure if you wanted system keys to not expire for some reason
fjcasti1
added a commit
that referenced
this pull request
Aug 16, 2024
* main: (58 commits) Update OpenAPI spec (#4260) Default to adding span annotations to queue (#4259) docs: Add human feedback notebook tutorial (#4257) refactor: daemon task abstraction (#4255) feat(auth): create system key (#4235) chore: add vision fixture (#4250) docs: fix variable name typo in run experiments doc (#4249) build(deps): bump certifi (#4147) chore(main): release arize-phoenix 4.24.0 (#4225) chore(main): release arize-phoenix-evals 0.15.0 (#3920) feat(experiments): ability to specify concurrency in run_experiment and evaluate_experiment (#4189) ci(evals): limit `mistralai` below version 1.0 (#4241) feat(auth): user / system api key resolvers (#4232) feat(auth): add user role, exclude system in user lists (#4229) docs: Add multimodal image reasoning tutorial with llama index (#4210) chore(main): release arize-phoenix 4.23.0 (#4216) docs: No subject (GITBOOK-818) build(deps): bump streamlit (#4214) fix: Propagate span annotation metadata to examples on all mutations (#4195) feat(auth): users table in settings (#4221) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #4234
This introduces create system API creation mutation. It is not wored up, is intended for scaffolding a working UI.
Payload
{ "data": { "createSystemApiKey": { "jwt": "eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJuYW1lIjoic3lzdGVtLWFwaS1rZXkiLCJkZXNjcmlwdGlvbiI6bnVsbCwiaWF0IjoxNzIzNjg3NTI4LCJpZCI6OH0.29TOm3JM2aY5vdALWnNlLA7cJXM1r3UZu3ApiqfEhpg", "apiKey": { "name": "system-api-key", "description": null, "createdAt": "2024-08-15T02:05:28+00:00", "expiresAt": null } } } }