fix: Propagate span annotation metadata to examples on all mutations

[anticorrelator]

Resolves #4167

Span annotations should be propagated to dataset example metadata when added. However this functionality wasn't available on all mutations that created dataset examples.

This PR ensures that even if creating a dataset example via the add_examples_to_dataset mutation, associated span annotations are added to the metadata.

[mikeldking]

@anticorrelator I think you fixed the wrong code path. If you test end-to-end I think you would see that you need to modify

phoenix/src/phoenix/server/api/types/Span.py

Line 235 in 7a9ad5e

def as_example_revision(self) -> SpanAsExampleRevision:

where the UI materializes the span as a dataset example before performing the create Mutation. Can you validate e2e that this PR works?

[anticorrelator]

@anticorrelator I think you fixed the wrong code path. If you test end-to-end I think you would see that you need to modify

phoenix/src/phoenix/server/api/types/Span.py

Line 235 in 7a9ad5e

def as_example_revision(self) -> SpanAsExampleRevision:

where the UI materializes the span as a dataset example before performing the create Mutation. Can you validate e2e that this PR works?

Sounds good, will verify. I think this might still work though, just with an incomplete preview. When we try to add the Example revision it'll then propagate the span annotations on insert as long as the span_id field is populated.