Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Numeric dimensions calculating cardinality, categories #476

Closed
mikeldking opened this issue Mar 30, 2023 · 2 comments · Fixed by #493
Closed

[BUG] Numeric dimensions calculating cardinality, categories #476

mikeldking opened this issue Mar 30, 2023 · 2 comments · Fixed by #493
Assignees
@RogerHYang
Labels
bug Something isn't working c/server Server implementation

Comments

@mikeldking
Copy link
Contributor

Describe the bug
When loading data in via CSV, numeric columns get cardinality and categories, causing the UI to get confused as to how to treat the dimension (I think)

To Reproduce
Steps to reproduce the behavior:

  1. Ingest the sea floor data (need to get from @arizedatngo )
  2. Note on the home page that the "depth" column gets a cardinality (https://us-18983.app.gong.io/call?id=906116718773531468&highlights=%5B%7B%22type%22%3A%22SHARE%22%2C%22from%22%3A1401%2C%22to%22%3A1476%7D%5D)
  3. Go to the embedding page - note that
    Expected behavior
    A clear and concise description of what you expected to happen.

Screenshots
Gong video (https://us-18983.app.gong.io/call?id=906116718773531468&highlights=%5B%7B%22type%22%3A%22SHARE%22%2C%22from%22%3A1401%2C%22to%22%3A1476%7D%5D)

Environment (please complete the following information):

  • OS: [MacOS]
  • Notebook Runtime [IntelliJ]
  • Browser [chrome]
  • Version [e.g. 0.0.6]

Additional context
Add any other context about the problem here (e.x. a link to a colab)
@mikeldking mikeldking added bug Something isn't working c/server Server implementation labels Mar 30, 2023
@mikeldking mikeldking self-assigned this Mar 30, 2023
@mikeldking
Copy link
Contributor Author

At least fix the numeric coloring for depth

@mikeldking mikeldking assigned RogerHYang and unassigned mikeldking Mar 30, 2023
@mikeldking
Copy link
Contributor Author

Treat ints as discrete, floats as ranges

@RogerHYang RogerHYang mentioned this issue Apr 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RogerHYang RogerHYang

Labels
bug Something isn't working c/server Server implementation
Projects
phoenix
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: exclude floats from cardinality Arize-ai/phoenix
2 participants
@mikeldking @RogerHYang