Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: exclude floats from cardinality #493

Merged
merged 4 commits into from
Apr 4, 2023
Merged

fix: exclude floats from cardinality #493

merged 4 commits into from
Apr 4, 2023

Conversation

RogerHYang
Copy link
Contributor

resolves #476

@RogerHYang RogerHYang changed the title fix: no cardinality for floats fix: exclude floats from cardinality Apr 3, 2023
mikeldking
mikeldking approved these changes Apr 3, 2023
View reviewed changes
Copy link
Contributor

@mikeldking mikeldking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RogerHYang any chance you can hunt down @arizedatngo 's data? could be useful as it was causing issues for the UMAP view as well.

@RogerHYang
Copy link
Contributor Author

RogerHYang commented Apr 4, 2023 •
edited
Loading

@RogerHYang any chance you can hunt down @arizedatngo 's data? could be useful as it was causing issues for the UMAP view as well.

@mikeldking I didn't see an issue with Depth for color-by on Dat's data. Not sure why it didn't work before.

Screenshot 2023-04-04 at 3 29 08 PM

@RogerHYang RogerHYang merged commit 8183737 into main Apr 4, 2023
@RogerHYang RogerHYang deleted the no-card-for-float branch April 4, 2023 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeldking mikeldking mikeldking approved these changes

@axiomofjoy axiomofjoy axiomofjoy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
phoenix
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Numeric dimensions calculating cardinality, categories
3 participants
@RogerHYang @mikeldking @axiomofjoy