Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[playground][ENHANCEMENT][ui] users should be notified upfront about missing model parameters that are required so they don't get confused by errors #5431

Open
Tracked by #3435
RogerHYang opened this issue Nov 19, 2024 · 1 comment · May be fixed by #5470
Assignees
Labels
c/ui enhancement New feature or request

Comments

@RogerHYang
Copy link
Contributor

RogerHYang commented Nov 19, 2024

As users switch between providers, some model parameters may be left blank unwittingly.

Some examples:

Azure OpenAI

  • api version

Anthropic

  • max tokens
@RogerHYang RogerHYang added enhancement New feature or request triage issues that need triage labels Nov 19, 2024
@github-project-automation github-project-automation bot moved this to 📘 Todo in phoenix Nov 19, 2024
@RogerHYang RogerHYang removed the triage issues that need triage label Nov 19, 2024
@RogerHYang RogerHYang changed the title [playground][ENHANCEMENT] users should be notified upfront about missing fields that are required so they don't get confused by errors [playground][ENHANCEMENT] users should be notified upfront about missing model parameters that are required so they don't get confused by errors Nov 19, 2024
@RogerHYang RogerHYang changed the title [playground][ENHANCEMENT] users should be notified upfront about missing model parameters that are required so they don't get confused by errors [playground][ENHANCEMENT][ui] users should be notified upfront about missing model parameters that are required so they don't get confused by errors Nov 19, 2024
@dosubot dosubot bot added the c/ui label Nov 19, 2024
@Parker-Stafford Parker-Stafford self-assigned this Nov 20, 2024
@cephalization
Copy link
Contributor

This requires us to fetch invocation parameter definitions at the top level of each instance, such the the definitions are available for the rest of the playground instance components to use.

Of note:

  • We would like to warn when all required invocation parameter definitions are not provided in the instance config form
  • Unsupported invocation parameters should be stripped before sending to gql client
  • extra credit tool defs and tool messages should be dropped when moving from a provider that supports tools to one that does not

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/ui enhancement New feature or request
Projects
Status: 🔍. Needs Review
3 participants