fix: Hide tool button on non-supported providers, Display errors for missing invocation params #5470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cephalization
force-pushed
the
cephalization/5462-disable-tools-invocation-params
branch
from
47b4b28
to
a4ff918
Compare
cephalization
changed the title
cephalization
commented
Nov 21, 2024
dosubot
bot
added
the
size:L
Parker-Stafford
approved these changes
Nov 22, 2024
cephalization
force-pushed
the
cephalization/5462-disable-tools-invocation-params
branch
from
66ac3c9
to
9ea9c1f
Compare
dosubot
bot
added
size:XL
|
Need to also hide defined tools for gemini |
Comment on lines
1133
to
1148
| currentInvocationParametersMap.get(paramKeyName)?.[ | ||
| toCamelCase( | ||
| param.invocationInputField || "" | ||
| ) as keyof InvocationParameterInput | ||
| ] != null || |
There was a problem hiding this comment.
we should pull this out to make it a bit easier to read. The toCamelCase is because all params are stored like that in the map? when would these things be out of sync? one needing to be camelCased cause the other already had been
There was a problem hiding this comment.
Good callout, done
…ache results in store Additionally moves invocation param filtering to just before making the completion queries, not when the invocation param form is opened
…ram fields are not provided
cephalization
force-pushed
the
cephalization/5462-disable-tools-invocation-params
branch
from
9ea9c1f
to
0c2d35d
Compare
cephalization
deleted the
cephalization/5462-disable-tools-invocation-params
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
filter-invalid-params-show-warnings.mov
Note the new warnings when params are not filled in.
Also note that I am able to submit gemini with a tool definition configured; It now gets stripped out and it was not before. This is possible because the completion submission logic is now aware of which parameters are supported by the api.
Resolves #5462
Resolves #5431