feat: percent empty #118
Merged
feat: percent empty #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 17, 2022 20:57
Closed
mikeldking
requested changes
Jan 24, 2023
src/phoenix/metrics/percent_empty.py
Outdated
Comment on lines
8
to
9
| def percent_empty(df: pd.DataFrame) -> "pd.Series[float]": | ||
| return df.isnull().sum() / df.shape[0] |
There was a problem hiding this comment.
need to pass in columns to run the compute over.
src/phoenix/metrics/percent_empty.py
Outdated
| import pandas as pd | ||
|
|
||
|
|
||
| def percent_empty(df: pd.DataFrame) -> "pd.Series[float]": |
There was a problem hiding this comment.
return dict mapping column_name to percent empty
src/phoenix/metrics/percent_empty.py
Outdated
| import pandas as pd | ||
|
|
||
|
|
||
| def percent_empty(df: pd.DataFrame) -> "pd.Series[float]": |
There was a problem hiding this comment.
Should return None if dataframe has no rows.
mikeldking
approved these changes
Feb 10, 2023
src/phoenix/metrics/percent_empty.py
Outdated
| num_records = dataframe.shape[0] | ||
| if num_records == 0: | ||
| return {col: None for col in column_names} | ||
| return dict(dataframe[column_names].isnull().sum() / dataframe.shape[0]) |
There was a problem hiding this comment.
addressed in 65c0d0e
Comment on lines
+47
to
+54
| def _get_percent_empty_dataloader(model: Model) -> DataLoader[str, Optional[float]]: | ||
| async def _percent_empty_load_function(column_names: List[str]) -> List[Optional[float]]: | ||
| column_name_to_percent_empty = percent_empty( | ||
| dataframe=model.primary_dataset.dataframe, column_names=column_names | ||
| ) | ||
| return [column_name_to_percent_empty[col] for col in column_names] | ||
|
|
||
| return DataLoader(load_fn=_percent_empty_load_function) |
There was a problem hiding this comment.
might not be worth a dataloader tbh
There was a problem hiding this comment.
will address in a separate pr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.