-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement median and add unit tests #119
Conversation
@RogerHYang Let me know what you think regarding additional unit tests, e.g., for NaN values. |
def median(df: pd.DataFrame) -> "pd.Series[float]": | ||
return df.median() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
similar to other metrics, requires a set of columns to run this on?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@axiomofjoy bump
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will address in a subsequent PR
@axiomofjoy don't forget to tag your issue |
Tracks #103 |
No description provided.