Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add default UMAP parameters in launch_app() #1224

Merged
merged 30 commits into from
Oct 5, 2023
Merged

feat: Add default UMAP parameters in launch_app() #1224

merged 30 commits into from
Oct 5, 2023

Commits on Aug 28, 2023

  1. Reaching till GraphQLWithContext

    @pbadhe
    pbadhe committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    8ea71bd View commit details
    Browse the repository at this point in the history

  2. typing.Dict not dict()

    @pbadhe
    pbadhe committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    689b6f5 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2023

  1. Merge branch 'main' into umap_params

    @pbadhe
    pbadhe authored Sep 9, 2023
    Configuration menu
    Copy the full SHA
    5146c6e View commit details
    Browse the repository at this point in the history

  2. Dict import

    @pbadhe
    pbadhe committed Sep 9, 2023
    Configuration menu
    Copy the full SHA
    2834175 View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2023

  1. Merge branch 'main' into umap_params

    @pbadhe
    pbadhe authored Sep 15, 2023
    Configuration menu
    Copy the full SHA
    c532d04 View commit details
    Browse the repository at this point in the history

  2. Suggested review changes 

    Added validation, moved umap_params to pointcloud and removed Optional for self.umap_parameters in context
    @pbadhe
    pbadhe committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    5e195e4 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2023

  1. Merge branch 'main' into umap_params

    @pbadhe
    pbadhe authored Sep 26, 2023
    Configuration menu
    Copy the full SHA
    dc9992b View commit details
    Browse the repository at this point in the history

  2. CamelCase -> SnakeCase 

    Co-authored-by: Mikyo King <mikeldking@gmail.com>
    @pbadhe @mikeldking
    pbadhe and mikeldking authored Sep 26, 2023
    Configuration menu
    Copy the full SHA
    b71de1a View commit details
    Browse the repository at this point in the history

  3. CamelCase -> SnakeCase all suggested changes 

    Co-authored-by: Mikyo King <mikeldking@gmail.com>
    @pbadhe @mikeldking
    pbadhe and mikeldking authored Sep 26, 2023
    Configuration menu
    Copy the full SHA
    e1f9304 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2023

  1. Merge branch 'main' into umap_params

    @pbadhe
    pbadhe authored Sep 27, 2023
    Configuration menu
    Copy the full SHA
    a2f525d View commit details
    Browse the repository at this point in the history

  2. Default UMAPparam changes 

    Removed hardcoded defaults for single source of truth.
    @pbadhe
    pbadhe committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    91f5f47 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2023

  1. Merge branch 'main' into umap_params

    @pbadhe
    pbadhe authored Sep 29, 2023
    Configuration menu
    Copy the full SHA
    d4673ba View commit details
    Browse the repository at this point in the history

  2. typing hints & process_session() 

    Process_session() error. Logs at -> https://textdoc.co/maM9oCZwexUA4EWQ
    @pbadhe
    pbadhe committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    eb16a0d View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into umap_params

    @pbadhe
    pbadhe authored Sep 29, 2023
    Configuration menu
    Copy the full SHA
    6f2f8e6 View commit details
    Browse the repository at this point in the history

  4. Prettier check 

    I'd installed the pre-commit hooks, but "black ." was taking too long and checking venv lib packages, so I was doing it manually just on src/*.
    @pbadhe
    pbadhe committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    0be3164 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2023

  1. Merge branch 'main' into umap_params

    @mikeldking
    mikeldking authored Oct 4, 2023
    Configuration menu
    Copy the full SHA
    bc4a8bc View commit details
    Browse the repository at this point in the history

  2. Adjust frontend

    @mikeldking
    mikeldking committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    08f3a57 View commit details
    Browse the repository at this point in the history

  3. parse string correctly

    @mikeldking
    mikeldking committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    4975122 View commit details
    Browse the repository at this point in the history

  4. fix duplicate lines

    @mikeldking
    mikeldking committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    aa2fb82 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into umap_params

    @mikeldking
    mikeldking authored Oct 4, 2023
    Configuration menu
    Copy the full SHA
    6756ee4 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2023

  1. Update umap_parameters.py 

    Co-authored-by: Roger Yang <80478925+RogerHYang@users.noreply.github.com>
    @mikeldking @RogerHYang
    mikeldking and RogerHYang authored Oct 5, 2023
    Configuration menu
    Copy the full SHA
    7687b3b View commit details
    Browse the repository at this point in the history

  2. Update umap_parameters.py 

    Co-authored-by: Roger Yang <80478925+RogerHYang@users.noreply.github.com>
    @mikeldking @RogerHYang
    mikeldking and RogerHYang authored Oct 5, 2023
    Configuration menu
    Copy the full SHA
    7aa84a6 View commit details
    Browse the repository at this point in the history

  3. Update umap_parameters.py 

    Co-authored-by: Roger Yang <80478925+RogerHYang@users.noreply.github.com>
    @mikeldking @RogerHYang
    mikeldking and RogerHYang authored Oct 5, 2023
    Configuration menu
    Copy the full SHA
    83f6ea5 View commit details
    Browse the repository at this point in the history

  4. Update src/phoenix/session/session.py 

    Co-authored-by: Roger Yang <80478925+RogerHYang@users.noreply.github.com>
    @mikeldking @RogerHYang
    mikeldking and RogerHYang authored Oct 5, 2023
    Configuration menu
    Copy the full SHA
    800f85b View commit details
    Browse the repository at this point in the history

  5. Update src/phoenix/session/session.py 

    Co-authored-by: Roger Yang <80478925+RogerHYang@users.noreply.github.com>
    @mikeldking @RogerHYang
    mikeldking and RogerHYang authored Oct 5, 2023
    Configuration menu
    Copy the full SHA
    7ff011f View commit details
    Browse the repository at this point in the history

  6. Update src/phoenix/session/session.py 

    Co-authored-by: Roger Yang <80478925+RogerHYang@users.noreply.github.com>
    @mikeldking @RogerHYang
    mikeldking and RogerHYang authored Oct 5, 2023
    Configuration menu
    Copy the full SHA
    194a1ea View commit details
    Browse the repository at this point in the history

  7. use positional arguments

    @mikeldking
    mikeldking committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    4a30132 View commit details
    Browse the repository at this point in the history

  8. fix style and imports

    @mikeldking
    mikeldking committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    fbf87e4 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'main' into umap_params

    @mikeldking
    mikeldking authored Oct 5, 2023
    Configuration menu
    Copy the full SHA
    5b05baa View commit details
    Browse the repository at this point in the history

  10. Merge branch 'main' into umap_params

    @mikeldking
    mikeldking authored Oct 5, 2023
    Configuration menu
    Copy the full SHA
    4c411be View commit details
    Browse the repository at this point in the history