Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: graphql scaffolding #130

Merged
merged 2 commits into from
Dec 22, 2022
Merged

feat: graphql scaffolding #130

merged 2 commits into from
Dec 22, 2022

Conversation

mikeldking
Copy link
Contributor

No description provided.

axiomofjoy
axiomofjoy approved these changes Dec 22, 2022
View reviewed changes
Copy link
Contributor

@axiomofjoy axiomofjoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Camel case pretty unusual for file names, usually see snake case.

src/phoenix/server/api/types/pagination.py Show resolved Hide resolved
@mikeldking
Copy link
Contributor Author

Camel case pretty unusual for file names, usually see snake case.

GraphqQL is commonly camel cased so we are going that direction. Expecially since the pagination spec is camel cased. You can try out one here: Ex.https://docs.github.com/en/graphql/overview/explorer

@mikeldking
Copy link
Contributor Author

Going to merge - it's not 100% relay compliant but will give me something to work against for data fetching

@mikeldking mikeldking merged commit 2acb121 into main Dec 22, 2022
@mikeldking mikeldking deleted the graphql-strawman branch December 22, 2022 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axiomofjoy axiomofjoy axiomofjoy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikeldking @axiomofjoy