Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cardinality to return num unique values per dimension #137

Merged
merged 2 commits into from
Dec 30, 2022

Conversation

axiomofjoy
Copy link
Contributor

@axiomofjoy axiomofjoy commented Dec 29, 2022

Previously, cardinality metric returned a pd.Series object for each input dimension describing the count of each unique value. Now, it returns a count for the number of unique values (including nans) in each input dimension.

@axiomofjoy axiomofjoy marked this pull request as ready for review December 29, 2022 06:40
@axiomofjoy axiomofjoy linked an issue Dec 29, 2022 that may be closed by this pull request
src/phoenix/metrics/cardinality.py Show resolved Hide resolved
tests/metrics/test_cardinality.py Outdated Show resolved Hide resolved
tests/metrics/test_cardinality.py Show resolved Hide resolved
@axiomofjoy axiomofjoy merged commit ead0a44 into main Dec 30, 2022
@axiomofjoy axiomofjoy deleted the fix/cardinality-returns-int branch December 30, 2022 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[metrics] Cardinality for each bin for categorical data
2 participants