Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(trace): add live updating UI, stream on/off switch #1554

Merged
merged 8 commits into from
Oct 4, 2023

Conversation

mikeldking
Copy link
Contributor

@mikeldking mikeldking commented Oct 4, 2023

resolves #1554

This adds live streaming in the UI without the use of subscriptions. The strategy is a bit different - it now keeps track of the number of traces via a refetchable fragment - if the count of traces changes, the entire page's query is re-loaded. In addition a toggle is added to pause the "streaming" so that the user can navigate the UI in peace.

Built-in.Retina.Display.mp4

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@mikeldking mikeldking changed the title 1543 live updating ui feat(trace): add live updating UI, stream on/off switch Oct 4, 2023
Copy link
Contributor

@RogerHYang RogerHYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works on my machine!

@mikeldking mikeldking merged commit 92e53bf into main Oct 4, 2023
10 checks passed
@mikeldking mikeldking deleted the 1543-live-updating-ui branch October 4, 2023 19:44
@github-actions github-actions bot locked and limited conversation to collaborators Oct 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants