Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: type check for on_event_start for llama-index #1557

Merged
merged 3 commits into from
Oct 4, 2023
Merged

fix: type check for on_event_start for llama-index #1557

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e71fb54
add new parameter
RogerHYang Oct 4, 2023
b170add
Merge branch 'main' into fix-type-check-for-on-event-start
RogerHYang Oct 4, 2023
b2b86f2
black
mikeldking Oct 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions scripts/data/build_llama_index_with_markdown_section_summaries.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,11 @@
from llama_index.embeddings import OpenAIEmbedding
from llama_index.llms import OpenAI
from llama_index.node_parser import SimpleNodeParser
from llama_index.node_parser.extractors import (MetadataExtractor,
QuestionsAnsweredExtractor,
SummaryExtractor)
from llama_index.node_parser.extractors import (
MetadataExtractor,
QuestionsAnsweredExtractor,
SummaryExtractor,
)
from llama_index.schema import Document
from llama_index.text_splitter import SentenceSplitter

Expand Down
1 change: 1 addition & 0 deletions src/phoenix/trace/llama_index/callback.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,7 @@ def on_event_start(
event_type: CBEventType,
payload: Optional[Dict[str, Any]] = None,
event_id: CBEventID = "",
parent_id: CBEventID = "",
**kwargs: Any,
) -> CBEventID:
event_id = event_id or str(uuid4())
Expand Down
Loading