Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(traces): add reranking span kind for document reranking in llama index #1588

Merged
merged 13 commits into from
Oct 12, 2023
Merged

feat(traces): add reranking span kind for document reranking in llama index #1588

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
04e6ab2
add reranking span
RogerHYang Oct 7, 2023
245441c
Merge branch 'main' into llama-index-reranking
RogerHYang Oct 7, 2023
5019bf6
add icon and color
mikeldking Oct 10, 2023
3d2885d
remove console.log
mikeldking Oct 10, 2023
86c82a3
Merge branch 'main' into llama-index-reranking
RogerHYang Oct 11, 2023
1bb7467
Merge branch 'main' into llama-index-reranking
RogerHYang Oct 12, 2023
71e34b0
add titleExtra
RogerHYang Oct 12, 2023
8df4c04
rename reranking to reranker
RogerHYang Oct 12, 2023
b79bbdf
clean up
RogerHYang Oct 12, 2023
58cf84c
revert demo notebook
RogerHYang Oct 12, 2023
58294db
Revert "revert demo notebook"
RogerHYang Oct 12, 2023
374fa32
bump deps
mikeldking Oct 12, 2023
c50c3d3
add rerank fixture, color reranked documents differently
mikeldking Oct 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 2 additions & 19 deletions tutorials/internal/llama_index_tracing_example.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@
"from llama_index.callbacks import CallbackManager\n",
"from llama_index.embeddings.openai import OpenAIEmbedding\n",
"from llama_index.graph_stores.simple import SimpleGraphStore\n",
"from llama_index.indices.postprocessor.cohere_rerank import CohereRerank\n",
"from phoenix.trace.llama_index import (\n",
" OpenInferenceTraceCallbackHandler,\n",
")\n",
Expand All @@ -76,11 +75,7 @@
"if not (openai_api_key := os.getenv(\"OPENAI_API_KEY\")):\n",
" openai_api_key = getpass(\"🔑 Enter your OpenAI API key: \")\n",
"openai.api_key = openai_api_key\n",
"os.environ[\"OPENAI_API_KEY\"] = openai_api_key\n",
"\n",
"if not (cohere_api_key := os.getenv(\"COHERE_API_KEY\")):\n",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the internal one - it seemed nice to have a notebook that executed a reranker?

Copy link
Contributor Author

@RogerHYang RogerHYang Oct 12, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, my bad. I had mistaken this one with the public notebook llama_index_tracing_tutorial.ipynb which has a very similar name.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reverted

" cohere_api_key = getpass(\"🔑 Enter your COHERE API key: \")\n",
"os.environ[\"COHERE_API_KEY\"] = cohere_api_key"
"os.environ[\"OPENAI_API_KEY\"] = openai_api_key"
]
},
{
Expand Down Expand Up @@ -145,10 +140,7 @@
" storage_context,\n",
" service_context=service_context,\n",
")\n",
"reranker = CohereRerank(top_n=2)\n",
"query_engine = index.as_query_engine(\n",
" node_postprocessors=[reranker],\n",
")"
"query_engine = index.as_query_engine()"
]
},
{
Expand All @@ -175,15 +167,6 @@
"queries"
]
},
{
"cell_type": "code",
"execution_count": null,
"metadata": {},
"outputs": [],
"source": [
"px.launch_app()"
]
},
{
"cell_type": "code",
"execution_count": null,
Expand Down