Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement feature discovery & excludes + deprecate parquet class methods #167

Merged
merged 20 commits into from
Jan 18, 2023
Merged

feat: implement feature discovery & excludes + deprecate parquet class methods #167

merged 20 commits into from
Jan 18, 2023

Conversation

axiomofjoy
Copy link
Contributor

No description provided.

@axiomofjoy axiomofjoy changed the title feat: implement feature discovery & excludes + deprecate parquet class methods feat: wip implement feature discovery & excludes + deprecate parquet class methods Jan 13, 2023
@axiomofjoy axiomofjoy marked this pull request as ready for review January 14, 2023 02:02
@axiomofjoy axiomofjoy changed the title feat: wip implement feature discovery & excludes + deprecate parquet class methods feat: implement feature discovery & excludes + deprecate parquet class methods Jan 14, 2023
This was linked to issues Jan 17, 2023
[datasets] make feature_column_names optional (Feature discovery) #162
Closed
deprecate from_parquet #175
Closed
[datasets] Add excluded fields to schema #176
Closed
mikeldking
mikeldking approved these changes Jan 17, 2023
View reviewed changes
src/phoenix/datasets/parsing.py Outdated Show resolved Hide resolved
src/phoenix/datasets/parsing.py Outdated Show resolved Hide resolved
src/phoenix/datasets/parsing.py Outdated Show resolved Hide resolved
src/phoenix/datasets/parsing.py Outdated Show resolved Hide resolved
src/phoenix/datasets/parsing.py Outdated Show resolved Hide resolved
src/phoenix/datasets/parsing.py Outdated Show resolved Hide resolved
src/phoenix/datasets/parsing.py Outdated Show resolved Hide resolved
src/phoenix/datasets/parsing.py Outdated Show resolved Hide resolved
src/phoenix/datasets/parsing.py Outdated Show resolved Hide resolved
src/phoenix/datasets/parsing.py Outdated Show resolved Hide resolved
mikeldking
mikeldking approved these changes Jan 18, 2023
View reviewed changes
Copy link
Contributor

@mikeldking mikeldking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let some notes, no need to re-factor right now if you don't have time. Let's get this code exercised with the larger, more realistic datasets and see how it goes.

src/phoenix/datasets/dataset.py Outdated Show resolved Hide resolved
src/phoenix/datasets/dataset.py Outdated Show resolved Hide resolved
src/phoenix/datasets/dataset.py Outdated Show resolved Hide resolved
src/phoenix/datasets/dataset.py Outdated Show resolved Hide resolved
src/phoenix/datasets/dataset.py Outdated Show resolved Hide resolved
src/phoenix/datasets/dataset.py Outdated Show resolved Hide resolved
src/phoenix/datasets/dataset.py Outdated Show resolved Hide resolved
src/phoenix/datasets/dataset.py Outdated Show resolved Hide resolved
@axiomofjoy axiomofjoy merged commit e5b107b into main Jan 18, 2023
@axiomofjoy axiomofjoy deleted the feat/feature-discovery branch January 18, 2023 19:59
@axiomofjoy axiomofjoy mentioned this pull request Jan 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeldking mikeldking mikeldking approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@axiomofjoy @mikeldking