Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: revise point cloud plumbing and add unit tests #205
refactor!: revise point cloud plumbing and add unit tests #205
Changes from all commits
19dff6e
ea447a8
2e9d8ba
2c229e9
df295ec
204c494
f988b1c
234034b
7bd8023
e2c0429
8fbec26
71e28b4
4ccbb23
b1b640e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a need for this generic? trying to understand what you mean by an identifier here. A doc-string could help here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's mostly a placeholder. I see that we have used
uuid
(which is astr
) as an identifier for theprediction_id
, so it could be just astr
in the dict key, but it's a dynamic language, so it could work if theprediction_id
is a number (e.g. row number). Making it generic here is just to keep the typing flexible.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it - I think we should probably consider not over abstracting but this is neat.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this not corralate with the type?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point. i was looking for examples from other code bases but haven't found any, so kind of just gave up. i wasn't sure if these types variables belong in a docstring since they're local constructs relevant only to the type checker