feat: sort dataframe rows by time #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axiomofjoy
commented
Feb 8, 2023
| @@ -50,6 +50,7 @@ def __init__( | |||
| name: Optional[str] = None, | |||
| persist_to_disc: bool = True, | |||
| ): | |||
| dataframe = dataframe.reset_index() | |||
There was a problem hiding this comment.
If an input dataframe has an index containing one of the columns defined in the schema, our current validation code will fail with a missing column error since such a column is part of dataframe.index and not part of dataframe.columns.
There was a problem hiding this comment.
this makes sense. we won't need any index we don't use
axiomofjoy
changed the title
RogerHYang
approved these changes
Feb 9, 2023
axiomofjoy
changed the title
axiomofjoy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #230