feat(persistence): migrations support #2748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XL
dosubot
bot
added
size:L
refactor
RogerHYang
approved these changes
Apr 4, 2024
| sa.Column("id", sa.Integer, primary_key=True), | ||
| sa.Column("name", sa.String, nullable=False), | ||
| sa.Column("description", sa.String, nullable=True), | ||
| # TODO(mikeldking): is timezone=True necessary? |
There was a problem hiding this comment.
Yea, it doesn't work with sqlite, because it just stores it as strings. I end up having to call isofomat() manually. Maybe this is useful for other vendors. Ultimately, having a timezone-aware python datetime should be the expectation.
src/phoenix/db/models.py
Outdated
| @@ -51,6 +54,7 @@ class Trace(Base): | |||
| project_rowid: Mapped[int] = mapped_column(ForeignKey("projects.id")) | |||
| session_id: Mapped[Optional[str]] | |||
| trace_id: Mapped[str] | |||
| # TODO(mikeldking): why is the start and end time necessary? just filtering? | |||
There was a problem hiding this comment.
Yes, because there are moments in time where we can have multiple "root" spans (because the ultimate root has not arrived).
Co-authored-by: Roger Yang <80478925+RogerHYang@users.noreply.github.com>
Co-authored-by: Roger Yang <80478925+RogerHYang@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2742
This adds runtime migration support via alembic.
NB: Migrations DO NOT work on in memory sqlite so Base.metadata.create_all() is necessary.
Of note that this PR adds naming convention rules as well.