Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(persistence): span annotation tables #2788

Merged
merged 10 commits into from
Apr 9, 2024
Merged

feat(persistence): span annotation tables #2788

merged 10 commits into from
Apr 9, 2024

Conversation

mikeldking
Copy link
Contributor

@mikeldking mikeldking commented Apr 5, 2024 •
edited
Loading

resolves #2776

@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Apr 5, 2024
@mikeldking mikeldking changed the base branch from main to sql April 5, 2024 23:27
@mikeldking mikeldking marked this pull request as draft April 5, 2024 23:28
@mikeldking mikeldking removed the size:XXL This PR changes 1000+ lines, ignoring generated files. label Apr 5, 2024
mikeldking
mikeldking commented Apr 5, 2024
View reviewed changes
src/phoenix/db/models.py Outdated Show resolved Hide resolved
@mikeldking mikeldking changed the title annotation tables feat(persistence): annotation tables Apr 5, 2024
mikeldking
mikeldking commented Apr 6, 2024
View reviewed changes
src/phoenix/db/models.py Outdated Show resolved Hide resolved
mikeldking
mikeldking commented Apr 6, 2024
View reviewed changes
src/phoenix/db/models.py Outdated Show resolved Hide resolved
@axiomofjoy
Copy link
Contributor

Screenshot 2024-04-08 at 5 30 04 PM

I don't think the onupdate argument is working as expected at the moment.

axiomofjoy
axiomofjoy reviewed Apr 9, 2024
View reviewed changes
src/phoenix/db/models.py Outdated Show resolved Hide resolved
@axiomofjoy axiomofjoy marked this pull request as ready for review April 9, 2024 00:36
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Apr 9, 2024
@axiomofjoy axiomofjoy changed the title feat(persistence): annotation tables feat(persistence): span annotation tables Apr 9, 2024
@axiomofjoy axiomofjoy merged commit 874c61e into sql Apr 9, 2024
12 checks passed
@axiomofjoy axiomofjoy deleted the annotation-tables branch April 9, 2024 04:02
mikeldking added a commit that referenced this pull request Apr 9, 2024
@mikeldking @axiomofjoy
feat(persistence): span annotation tables (#2788)
b613bcd 
adds span annotations table

---------

Co-authored-by: Alexander Song <axiomofjoy@gmail.com>
This was referenced Apr 12, 2024
Closed
Merged
Merged
@github-actions github-actions bot mentioned this pull request May 9, 2024
Closed
@mikeldking mikeldking mentioned this pull request May 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axiomofjoy axiomofjoy axiomofjoy left review comments

@RogerHYang RogerHYang RogerHYang approved these changes

Assignees
No one assigned
Labels
size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikeldking @axiomofjoy @RogerHYang