Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support for span evaluations to get evaluations endpoint #2900

Merged
merged 6 commits into from
Apr 16, 2024
Merged

feat: support for span evaluations to get evaluations endpoint #2900

merged 6 commits into from
Apr 16, 2024

Conversation

axiomofjoy
Copy link
Contributor

@axiomofjoy axiomofjoy commented Apr 16, 2024 •
edited
Loading

  • adds support for span annotations to the GET evaluations endpoint.
  • fixes bug with query name parameter

resolves #2894

@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Apr 16, 2024
@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@axiomofjoy axiomofjoy changed the base branch from main to sql April 16, 2024 02:07
@axiomofjoy axiomofjoy added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Apr 16, 2024
mikeldking
mikeldking reviewed Apr 16, 2024
View reviewed changes
src/phoenix/session/client.py Outdated Show resolved Hide resolved
src/phoenix/server/api/routers/v1/evaluations.py Outdated Show resolved Hide resolved
src/phoenix/server/api/routers/v1/evaluations.py Outdated Show resolved Hide resolved
src/phoenix/server/api/routers/v1/evaluations.py Outdated Show resolved Hide resolved
src/phoenix/server/api/routers/v1/evaluations.py Outdated Show resolved Hide resolved
@axiomofjoy axiomofjoy mentioned this pull request Apr 16, 2024
Closed
@axiomofjoy axiomofjoy requested a review from mikeldking April 16, 2024 02:39
@axiomofjoy axiomofjoy merged commit 379e336 into sql Apr 16, 2024
11 checks passed
@axiomofjoy axiomofjoy deleted the get-evaluations-2894 branch April 16, 2024 18:52
@github-actions github-actions bot mentioned this pull request May 9, 2024
Closed
@mikeldking mikeldking mentioned this pull request May 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RogerHYang RogerHYang RogerHYang approved these changes

@mikeldking mikeldking Awaiting requested review from mikeldking

Assignees
No one assigned
Labels
size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[persistence] wire evaluations GET endpoint to db
3 participants
@axiomofjoy @mikeldking @RogerHYang