-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Add postgres testing #2973
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really nice. Let me know if you need help resolving conflicts.
0120042
to
1c67b0f
Compare
Think we need to update our developer guide to include instructions on installing postgresql, e.g., via |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work! let's remove the nest asyncio test cases and make them into proper unit tests, otherwise, looks good.
resolves #2783
session
fixture, this can be used to parametrize database tests to include either an emptysqlite
database session orpostgresql
database session.--skip-postgres
flag topytest