chore: add docker-compose.yml with postgres #3099
Conversation
dosubot
bot
added
the
size:M
| @@ -32,7 +32,11 @@ RUN pnpm run build | |||
| # The second stage builds the backend. | |||
| FROM python:3.11-bullseye as backend-builder | |||
| WORKDIR /phoenix | |||
| COPY ./ /phoenix/ | |||
There was a problem hiding this comment.
copying too much on local build (e.g. node_modules)
There was a problem hiding this comment.
Node modules shouldn't be copied, they are in .dockerignore. I think it keeps the Dockerfile simpler to avoid copying individual files. I'd also mention that none of the contents of this stage are included in the final build except for what is explicitly copied in the final step.
There was a problem hiding this comment.
ah ok. i guess it's copying the tox folder
There was a problem hiding this comment.
Got it. Can we add to .dockerignore instead?
There was a problem hiding this comment.
There are also other things like packages and docs. It's probably easier to copy just the specific files.
There was a problem hiding this comment.
Are we going to have more than one compose.yml for different configurations, e.g., also a separate for one SQLite? If so, should we rename this file to be more specific?
| COPY ./LICENSE /phoenix/ | ||
| COPY ./IP_NOTICE /phoenix/ | ||
| COPY ./README.md /phoenix/ |
There was a problem hiding this comment.
Doesn't make sense to copy these here since they are not included in the final image.
There was a problem hiding this comment.
these are needed by the pip install
No description provided.