Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: commit insert into alembic_version at the end of migration #3115

Merged
merged 1 commit into from
May 8, 2024
Merged

fix: commit insert into alembic_version at the end of migration #3115

merged 1 commit into from
May 8, 2024

Conversation

RogerHYang
Copy link
Contributor

Before

INFO  [sqlalchemy.engine.Engine] INSERT INTO alembic_version (version_num) VALUES ('cf03bd6bae1d') RETURNING version_num
INFO  [sqlalchemy.engine.Engine] [generated in 0.00034s] ()
INFO  [sqlalchemy.engine.Engine] ROLLBACK

After

INFO  [sqlalchemy.engine.Engine] INSERT INTO alembic_version (version_num) VALUES ('cf03bd6bae1d') RETURNING version_num
INFO  [sqlalchemy.engine.Engine] [generated in 0.00010s] ()
INFO  [sqlalchemy.engine.Engine] COMMIT

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label May 8, 2024
@RogerHYang RogerHYang merged commit 93a144f into sql May 8, 2024
11 checks passed
@RogerHYang RogerHYang deleted the RogerHYang-patch-4 branch May 8, 2024 16:11
This was referenced May 8, 2024
Closed
Closed
Closed
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeldking mikeldking mikeldking approved these changes

Assignees
No one assigned
Labels
size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RogerHYang @mikeldking