Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: index out of bound #332

Merged
merged 2 commits into from
Mar 6, 2023
Merged

fix: index out of bound #332

merged 2 commits into from
Mar 6, 2023

Conversation

RogerHYang
Copy link
Contributor

resolves: #331

mikeldking
mikeldking approved these changes Mar 6, 2023
View reviewed changes
src/phoenix/server/api/types/EmbeddingDimension.py Outdated Show resolved Hide resolved
src/phoenix/server/api/types/EmbeddingDimension.py Outdated Show resolved Hide resolved
@RogerHYang RogerHYang merged commit f1ddc35 into main Mar 6, 2023
@RogerHYang RogerHYang deleted the fix-out-of-bound branch March 6, 2023 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeldking mikeldking mikeldking approved these changes

@axiomofjoy axiomofjoy Awaiting requested review from axiomofjoy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Embeddings view broken when running with sentiment classification notebook
2 participants
@RogerHYang @mikeldking