Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(annotations): migrate span eval labels to us AnnotationLabel #4068

Merged
merged 10 commits into from
Jul 30, 2024
Merged

feat(annotations): migrate span eval labels to us AnnotationLabel #4068

merged 10 commits into from
Jul 30, 2024

Conversation

Parker-Stafford
Copy link
Contributor

@Parker-Stafford Parker-Stafford commented Jul 29, 2024 •
edited
Loading

resolves #3998

  • Migrates pre-existing span evaluations off of EvaluationLabel to Annotation label to make traces consistent with experiments and ready tracing pages for annotations work
  • document evals (metrics) are untouched

Screenshot 2024-07-29 at 12 48 41 PM

Screenshot 2024-07-29 at 12 47 47 PM

@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Jul 29, 2024
Parker-Stafford
Parker-Stafford commented Jul 29, 2024
View reviewed changes
app/src/components/experiment/AnnotationLabel.tsx

return (
<TooltipTrigger delay={500} offset={3}>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this diff is from moving Annotation tooltip to it's own component

Parker-Stafford
Parker-Stafford commented Jul 29, 2024
View reviewed changes
app/src/components/experiment/AnnotationTooltip.tsx Outdated
}) {
return (
<TooltipTrigger delay={500} offset={3}>
<TriggerWrap>{children}</TriggerWrap>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unchanged just pulled out of annotation label

mikeldking
mikeldking requested changes Jul 29, 2024
View reviewed changes
Copy link
Contributor

@mikeldking mikeldking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should move these label and tooltip behavior out of experiment since now it's being used across traces and experiments.

app/src/components/experiment/AnnotationLabel.tsx Outdated Show resolved Hide resolved
app/src/components/experiment/AnnotationLabel.tsx Outdated Show resolved Hide resolved
app/src/components/experiment/AnnotationLabel.tsx Outdated Show resolved Hide resolved
app/src/pages/project/SpansTable.tsx Outdated Show resolved Hide resolved
mikeldking
mikeldking reviewed Jul 30, 2024
View reviewed changes
app/src/components/annotation/types.ts Outdated Show resolved Hide resolved
app/src/components/annotation/types.ts
label?: string | null;
score?: number | null;
explanation?: string | null;
annotatorKind: string;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same with this - since it's not explicitly used, you should be able to remove this from the interface

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is used by the AnnotationTooltip

app/src/pages/example/ExampleExperimentRunsTable.tsx Outdated Show resolved Hide resolved
app/src/components/annotation/AnnotationLabel.tsx Outdated Show resolved Hide resolved
app/src/components/annotation/AnnotationLabel.tsx Outdated Show resolved Hide resolved
app/src/components/annotation/AnnotationLabel.tsx Outdated Show resolved Hide resolved
mikeldking
mikeldking approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@mikeldking mikeldking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@mikeldking mikeldking merged commit 6219e91 into main Jul 30, 2024
6 checks passed
@mikeldking mikeldking deleted the parker/3998-color-code-annotations branch July 30, 2024 18:34
@mikeldking mikeldking mentioned this pull request Jul 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeldking mikeldking mikeldking approved these changes

Assignees
No one assigned
Labels
size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ui][annotations] color code annotations in the table
2 participants
@Parker-Stafford @mikeldking