-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(annotations): migrate span eval labels to us AnnotationLabel #4068
Conversation
|
||
return ( | ||
<TooltipTrigger delay={500} offset={3}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this diff is from moving Annotation tooltip to it's own component
}) { | ||
return ( | ||
<TooltipTrigger delay={500} offset={3}> | ||
<TriggerWrap>{children}</TriggerWrap> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unchanged just pulled out of annotation label
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should move these label and tooltip behavior out of experiment since now it's being used across traces and experiments.
label?: string | null; | ||
score?: number | null; | ||
explanation?: string | null; | ||
annotatorKind: string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same with this - since it's not explicitly used, you should be able to remove this from the interface
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is used by the AnnotationTooltip
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
resolves #3998