feat(annotations): add feedback column to spans / traces tables with all annotations #4100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
mikeldking
reviewed
Aug 1, 2024
| {annotation.annotatorKind ? ( | ||
| <Flex direction="row" justifyContent="space-between"> | ||
| <Text weight="heavy" color="inherit"> | ||
| kind |
There was a problem hiding this comment.
can we spell out annotator? I think otherwise it's a bit confusing. That or I might go as far as saying let's hide this for now.
There was a problem hiding this comment.
i added annotator - think it makes sense to leave in but can remove if folks find it confusing. I myself found it useful for looking at which things i had added vs pre-existing evals
mikeldking
approved these changes
Aug 1, 2024
This was referenced Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #4074
feedbackScreen.Recording.2024-07-31.at.10.44.21.PM.mov