Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(embeddings): color by dimension #423

Merged
merged 5 commits into from
Mar 23, 2023
Merged

Conversation

mikeldking
Copy link
Contributor

@mikeldking mikeldking commented Mar 23, 2023

resolves #342
resolves #304
resolves #355
resolves #377

Adds the ability to color the point cloud by event dimensions. Does this by mapping all points to a distinct group. For numeric, it maps them to 10 evenly spaced groups for now.

Screen.Recording.2023-03-22.at.10.58.51.PM.mov
  • fix: clear selection on point-cloud reload
  • feat: add async load of data
  • feat: add dimension metadata fetching to the store
  • feat: color by categorical
  • feat: color by numeric

@mikeldking mikeldking changed the title 355 color by dimension feat(embeddings): color by dimension Mar 23, 2023
@mikeldking mikeldking marked this pull request as ready for review March 23, 2023 05:03
Copy link
Contributor

@RogerHYang RogerHYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks amazing!

@mikeldking mikeldking merged commit 1126bfc into main Mar 23, 2023
@mikeldking mikeldking deleted the 355-color-by-dimension branch March 23, 2023 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
2 participants