Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: convert DatasetDict to dict and add __repr__ for Dataset #425

Merged
merged 9 commits into from
Mar 23, 2023

Conversation

axiomofjoy
Copy link
Contributor

No description provided.

Comment on lines 28 to 31
- name: Set up python 3.10
- name: Set up python 3.8
uses: actions/setup-python@v4
with:
python-version: "3.10"
python-version: "3.8"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run type checks and linting on same version of Python we're testing on.

Copy link
Contributor

@RogerHYang RogerHYang Mar 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's probably ok to have the latest lint unless there are any specific problems. On the other hand, if we leave the versions different, people will always want to change it. haha

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was trying to fix a typing issue I was having, but downgrading the version did not work. Changed it back.

@axiomofjoy axiomofjoy self-assigned this Mar 23, 2023
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@axiomofjoy axiomofjoy merged commit a7b94fc into main Mar 23, 2023
@axiomofjoy axiomofjoy deleted the chore-repr branch March 23, 2023 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants