chore: convert DatasetDict to dict and add __repr__ for Dataset #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axiomofjoy
commented
Mar 23, 2023
.github/workflows/python-CI.yml
Outdated
Comment on lines
28
to
31
| - name: Set up python 3.10 | ||
| - name: Set up python 3.8 | ||
| uses: actions/setup-python@v4 | ||
| with: | ||
| python-version: "3.10" | ||
| python-version: "3.8" |
There was a problem hiding this comment.
Run type checks and linting on same version of Python we're testing on.
There was a problem hiding this comment.
it's probably ok to have the latest lint unless there are any specific problems. On the other hand, if we leave the versions different, people will always want to change it. haha
There was a problem hiding this comment.
I was trying to fix a typing issue I was having, but downgrading the version did not work. Changed it back.
RogerHYang
approved these changes
Mar 23, 2023
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.