Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(auth): system api keys ui #4270

Merged
merged 4 commits into from
Aug 20, 2024
Merged

feat(auth): system api keys ui #4270

merged 4 commits into from
Aug 20, 2024

Conversation

mikeldking
Copy link
Contributor

@mikeldking mikeldking commented Aug 18, 2024

resolves #4269

Screenshot 2024-08-19 at 2 54 11 PM

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Aug 18, 2024
@mikeldking mikeldking changed the title get system keys wired up feat(auth): system api keys ui Aug 18, 2024
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Aug 19, 2024
`}
>
<Flex direction="row" gap="size-100" alignItems="end">
<TextField label="API Key" isReadOnly value={jwt} minWidth="100%" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want to obscure it even though it's only displayed once - **** with copy to clipboard - change messaging a bit: "The API key will only be copyable once below..."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typically these are displayed once. it's similar to how github does thsee

Comment on lines +85 to +90
<Controller
name="name"
control={control}
rules={{
required: "System key name is required",
}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for my product level understanding - there can be multiple system keys, and they can all have different names, correct?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, and they can ultimately have the same name if they want

@mikeldking mikeldking merged commit 695fdea into main Aug 20, 2024
6 checks passed
@mikeldking mikeldking deleted the 4269-system-keys-ui branch August 20, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[auth][ui] system api keys
2 participants