feat(auth): system api keys ui #4270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
dosubot
bot
added
size:XL
| `} | ||
| > | ||
| <Flex direction="row" gap="size-100" alignItems="end"> | ||
| <TextField label="API Key" isReadOnly value={jwt} minWidth="100%" /> |
There was a problem hiding this comment.
do we want to obscure it even though it's only displayed once - **** with copy to clipboard - change messaging a bit: "The API key will only be copyable once below..."
There was a problem hiding this comment.
typically these are displayed once. it's similar to how github does thsee
Comment on lines
+85
to
+90
| <Controller | ||
| name="name" | ||
| control={control} | ||
| rules={{ | ||
| required: "System key name is required", | ||
| }} |
There was a problem hiding this comment.
for my product level understanding - there can be multiple system keys, and they can all have different names, correct?
There was a problem hiding this comment.
Yup, and they can ultimately have the same name if they want
Parker-Stafford
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #4269