feat: Implement serverside rate limiter #4431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
axiomofjoy
reviewed
Aug 29, 2024
src/phoenix/server/rate_limiters.py
Outdated
Comment on lines
127
to
128
| bucket = partition[key] | ||
| del partition[key] |
There was a problem hiding this comment.
Suggested change
| bucket = partition[key] | |
| del partition[key] | |
| bucket = partition.pop(key) |
axiomofjoy
approved these changes
Aug 29, 2024
anticorrelator
changed the title
login mutation
This was referenced Aug 30, 2024
RogerHYang
pushed a commit
that referenced
this pull request
Sep 4, 2024
* Spike out serverside rate limiting middleware * Refactor to keep multiple active partitions * Create StrawberryRateLimiter extension * Add rate limiter tests * Update extension to run synchronously * Ensure rate limiter extension works for both sync and async resolvers * Clean up type annotations * Improve tests and reset behavior * Clarify edge cases in testing and documentation * Use pop instead of `del` * Remove extension implementation
Parker-Stafford
pushed a commit
that referenced
this pull request
Sep 4, 2024
* Spike out serverside rate limiting middleware * Refactor to keep multiple active partitions * Create StrawberryRateLimiter extension * Add rate limiter tests * Update extension to run synchronously * Ensure rate limiter extension works for both sync and async resolvers * Clean up type annotations * Improve tests and reset behavior * Clarify edge cases in testing and documentation * Use pop instead of `del` * Remove extension implementation
RogerHYang
pushed a commit
that referenced
this pull request
Sep 4, 2024
* Spike out serverside rate limiting middleware * Refactor to keep multiple active partitions * Create StrawberryRateLimiter extension * Add rate limiter tests * Update extension to run synchronously * Ensure rate limiter extension works for both sync and async resolvers * Clean up type annotations * Improve tests and reset behavior * Clarify edge cases in testing and documentation * Use pop instead of `del` * Remove extension implementation
This was referenced Sep 4, 2024
RogerHYang
pushed a commit
that referenced
this pull request
Sep 21, 2024
* Spike out serverside rate limiting middleware * Refactor to keep multiple active partitions * Create StrawberryRateLimiter extension * Add rate limiter tests * Update extension to run synchronously * Ensure rate limiter extension works for both sync and async resolvers * Clean up type annotations * Improve tests and reset behavior * Clarify edge cases in testing and documentation * Use pop instead of `del` * Remove extension implementation
This was referenced Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #4344
loginroute by IP